Better epub import#1842
Open
CD-Z wants to merge 6 commits into
Open
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
Palloxin
reviewed
May 9, 2026
| }; | ||
|
|
||
| const stripHtml = (value: string) => { | ||
| const bodyMatch = value.match(/<body[^>]*>([\s\S]*?)<\/body>/i); |
Contributor
There was a problem hiding this comment.
/<body[^>]*>([^]*?)<\/body>/i
Palloxin
reviewed
May 9, 2026
| const bodyMatch = value.match(/<body[^>]*>([\s\S]*?)<\/body>/i); | ||
| const bodyContent = bodyMatch ? bodyMatch[1] : value; | ||
| return bodyContent | ||
| .replace(/<script[^>]*>[\s\S]*?<\/script>/gi, ' ') |
Contributor
There was a problem hiding this comment.
regex is faster if u replace every [\s\S] with [^]
Supposing ther egex used is javascript flavour
Collaborator
Author
|
This has nothing to do with the old pr. This is for import and the other was for export |
Contributor
wyJsNRw0.mp4dont forget |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Faster import
skip empty chapters / chapters with only title inside
added test
other small fixes
Not tested with lots of epubs