fix: resolve 'tag_name' error when offline in GithubUpdateChecker#1729
Open
luqs1 wants to merge 1 commit into
Open
fix: resolve 'tag_name' error when offline in GithubUpdateChecker#1729luqs1 wants to merge 1 commit into
luqs1 wants to merge 1 commit into
Conversation
This change adds defensive checks to ensure latestRelease and tag_name are defined before access. Note: This needs to be tested on an actual device in offline mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a
TypeError: Cannot read property 'tag_name' of undefinedthat occurs when the app is offline.Changes
useGithubUpdateCheckerto ensurelatestReleaseandtag_nameexist before use.useGithubUpdateCheckerreturn logic for better robustness.useCallbackfor stability.Note
This needs to be tested on an actual device in offline mode to verify the fix across different environments (minified bundles, etc.).