Add Guava comparators to further verify project's comparators (#7)

bp-alex · bp-alex · commit e6a863f8af53 · 2017-07-15T13:03:52.000+10:00
diff --git a/pom.xml b/pom.xml
@@ -101,6 +101,12 @@
       <version>4.1.13.Final</version>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>com.google.guava</groupId>
+      <artifactId>guava</artifactId>
+      <version>22.0</version>
+      <scope>test</scope>
+    </dependency>
     <dependency>
       <groupId>org.lmdbjava</groupId>
       <artifactId>lmdbjava-native-linux-x86_64</artifactId>
diff --git a/src/test/java/org/lmdbjava/ComparatorTest.java b/src/test/java/org/lmdbjava/ComparatorTest.java
@@ -20,10 +20,13 @@
 
 package org.lmdbjava;
 
+import com.google.common.primitives.SignedBytes;
+import com.google.common.primitives.UnsignedBytes;
 import io.netty.buffer.ByteBuf;
 import static io.netty.buffer.PooledByteBufAllocator.DEFAULT;
 import java.nio.ByteBuffer;
 import static java.nio.charset.StandardCharsets.US_ASCII;
+import java.util.Comparator;
 import org.agrona.DirectBuffer;
 import org.agrona.concurrent.UnsafeBuffer;
 import static org.hamcrest.core.Is.is;
@@ -72,7 +75,9 @@ public static Object[] data() {
     final ComparatorRunner ba = new ByteArrayRunner();
     final ComparatorRunner bb = new ByteBufferRunner();
     final ComparatorRunner netty = new NettyRunner();
-    return new Object[]{string, db, ba, bb, netty};
+    final ComparatorRunner gub = new GuavaUnsignedBytes();
+    final ComparatorRunner gsb = new GuavaSignedBytes();
+    return new Object[]{string, db, ba, bb, netty, gub, gsb};
   }
 
   private static byte[] buffer(final int... bytes) {
@@ -168,6 +173,30 @@ public int compare(final byte[] o1, final byte[] o2) {
     }
   }
 
+  /**
+   * Tests using Guava's {@link SignedBytes} comparator.
+   */
+  private static class GuavaSignedBytes implements ComparatorRunner {
+
+    @Override
+    public int compare(final byte[] o1, final byte[] o2) {
+      final Comparator<byte[]> c = SignedBytes.lexicographicalComparator();
+      return c.compare(o1, o2);
+    }
+  }
+
+  /**
+   * Tests using Guava's {@link UnsignedBytes} comparator.
+   */
+  private static class GuavaUnsignedBytes implements ComparatorRunner {
+
+    @Override
+    public int compare(final byte[] o1, final byte[] o2) {
+      final Comparator<byte[]> c = UnsignedBytes.lexicographicalComparator();
+      return c.compare(o1, o2);
+    }
+  }
+
   /**
    * Tests {@link ByteBufProxy}.
    */
