Add more test coverage

at055612 · at055612 · commit a82d7f234d33 · 2025-11-06T12:38:47.000Z
diff --git a/src/main/java/org/lmdbjava/Env.java b/src/main/java/org/lmdbjava/Env.java
@@ -115,7 +115,6 @@ public static <T> Builder<T> create(final BufferProxy<T> proxy) {
    */
   @Deprecated
   public static Env<ByteBuffer> open(final File path, final int size, final EnvFlags... flags) {
-
     return new Builder<>(PROXY_OPTIMAL)
         .setMapSize(size, ByteUnit.MEBIBYTES)
         .open(path, flags);
@@ -678,13 +677,15 @@ public static final class Builder<T> {
 
     static final int MAX_READERS_DEFAULT = 126;
     static final long MAP_SIZE_DEFAULT = ByteUnit.MEBIBYTES.toBytes(1);
+    static final int POSIX_MODE_DEFAULT = 0664;
+
     private long mapSize = MAP_SIZE_DEFAULT;
     private int maxDbs = 1;
     private int maxReaders = MAX_READERS_DEFAULT;
     private boolean opened;
     private final BufferProxy<T> proxy;
-    private int mode = 0664;
-    private AbstractFlagSet.Builder<EnvFlags, EnvFlagSet> flagSetBuilder = EnvFlagSet.builder();
+    private int mode = POSIX_MODE_DEFAULT;
+    private final AbstractFlagSet.Builder<EnvFlags, EnvFlagSet> flagSetBuilder = EnvFlagSet.builder();
 
     Builder(final BufferProxy<T> proxy) {
       requireNonNull(proxy);
diff --git a/src/main/java/org/lmdbjava/FlagSet.java b/src/main/java/org/lmdbjava/FlagSet.java
@@ -55,6 +55,11 @@ default int getMaskWith(final FlagSet<T> other) {
    */
   boolean isSet(T flag);
 
+  /**
+   * @return The number of flags in this set.
+   */
+  int size();
+
   /**
    * @return True if at least one of flags are included in thie {@link FlagSet}
    */
@@ -71,19 +76,11 @@ default boolean areAnySet(final FlagSet<T> flags) {
     return false;
   }
 
-  /**
-   * @return The size of this {@link FlagSet}
-   */
-  default int size() {
-    return getFlags().size();
-  }
 
   /**
    * @return True if this {@link FlagSet} is empty.
    */
-  default boolean isEmpty() {
-    return getFlags().isEmpty();
-  }
+  boolean isEmpty();
 
   /**
    * @return The {@link Iterator} (in no particular order) for the flags in this {@link FlagSet}.
diff --git a/src/test/java/org/lmdbjava/AbstractFlagSetTest.java b/src/test/java/org/lmdbjava/AbstractFlagSetTest.java
@@ -45,10 +45,6 @@ T getFirst() {
     return getAllFlags().get(0);
   }
 
-  int getFlagCount() {
-    return getAllFlags().size();
-  }
-
   @Test
   void testEmpty() {
     final F emptyFlagSet = getEmptyFlagSet();
@@ -81,6 +77,12 @@ void testSingleFlagSet() {
           .containsExactly(flag);
       assertThat(flagSet.size())
           .isEqualTo(1);
+      assertThat(FlagSet.equals(flagSet, new Object()))
+          .isFalse();
+      assertThat(FlagSet.equals(flagSet, null))
+          .isFalse();
+      assertThat(FlagSet.equals(flag, flag))
+          .isTrue();
       assertThat(FlagSet.equals(flagSet, flag))
           .isTrue();
       assertThat(FlagSet.equals(flagSet, getFlagSet(flag)))
@@ -89,6 +91,10 @@ void testSingleFlagSet() {
           .isTrue();
       assertThat(flagSet.areAnySet(flag))
           .isTrue();
+      assertThat(flagSet.areAnySet(null))
+          .isFalse();
+      assertThat(flagSet.areAnySet(getEmptyFlagSet()))
+          .isFalse();
       assertThat(flagSet.isSet(getFirst()))
           .isEqualTo(getFirst() == flag);
       if (getFirst() == flag) {
@@ -97,11 +103,15 @@ void testSingleFlagSet() {
       } else {
         assertThat(flagSet.getMask())
             .isNotEqualTo(MaskedFlag.mask(getFirst()));
+        assertThat(flagSet.getMaskWith(getFirst()))
+            .isEqualTo(MaskedFlag.mask(flag, getFirst()));
       }
       assertThat(flagSet.toString())
           .isNotNull();
       assertThat(flag.name())
           .isNotNull();
+      assertThat(flagSet.getMaskWith(null))
+          .isEqualTo(flagSet.getMask());
     }
   }
 
