Skip to content

Commit 7dfb520

Browse files
committed
Contributing guidelines
1 parent 1a21fff commit 7dfb520

File tree

2 files changed

+31
-6
lines changed

2 files changed

+31
-6
lines changed

CONTRIBUTING.md

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
= Contributing Guidelines
2+
3+
We welcome patches and pull requests to improve LmdbJava.
4+
5+
For small changes, please simply submit a
6+
[pull request](https://github.com/lmdbjava/lmdbjava/pulls).
7+
8+
For larger changes, please
9+
[open a GitHub issue](https://github.com/lmdbjava/lmdbjava/issues) first so that
10+
we can discuss what you have in mind.
11+
12+
All engineering decisions require trade-offs, which is why we have an ordered list of
13+
[priorites](https://github.com/lmdbjava/lmdbjava/blob/master/src/main/java/org/lmdbjava/package-info.java).
14+
Please ensure your changes reflect those priorities.
15+
16+
In terms of style, use the current code as your guide. Highlights:
17+
18+
* Add the copyright header to each file
19+
* Use `final`
20+
* Use `import static`
21+
* Keep methods short and clear
22+
* Exceptions extend `LmdbException` and are typically static inner classes
23+
* JavaDocs are needed for public types and methods
24+
* Test coverage is important (Travis and Coveralls run for every pull request)
25+
26+
If you have any questions, please
27+
[open a GitHub issue](https://github.com/lmdbjava/lmdbjava/issues) and we'll be
28+
pleased to help.
29+
30+
Thanks for your interest in contributing!

README.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,7 @@ any questions.
3838

3939
## Contributing
4040

41-
Contributions are welcome! Simply submit a pull request that's consistent with
42-
the existing coding style and includes an appropriate test.
43-
44-
For larger changes, please
45-
[open a GitHub issue](https://github.com/lmdbjava/lmdbjava/issues) so we can
46-
discuss what you have in mind.
41+
Contributions are welcome! Please see the [Contributing Guidelines](CONTRIBUTING.md).
4742

4843
## History
4944

0 commit comments

Comments
 (0)