private static final classes to be final (checkstyle)

bp-alex · bp-alex · commit 790212695d21 · 2023-08-22T16:23:33.000+10:00
diff --git a/src/test/java/org/lmdbjava/ComparatorTest.java b/src/test/java/org/lmdbjava/ComparatorTest.java
@@ -143,7 +143,7 @@ public void equalBuffers() {
   /**
    * Tests {@link ByteArrayProxy}.
    */
-  private static class ByteArrayRunner implements ComparatorRunner {
+  private static final class ByteArrayRunner implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -155,7 +155,7 @@ public int compare(final byte[] o1, final byte[] o2) {
   /**
    * Tests {@link ByteBufferProxy}.
    */
-  private static class ByteBufferRunner implements ComparatorRunner {
+  private static final class ByteBufferRunner implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -199,7 +199,7 @@ private ByteBuffer arrayToBuffer(final byte[] arr, final int bufferCapacity) {
   /**
    * Tests {@link DirectBufferProxy}.
    */
-  private static class DirectBufferRunner implements ComparatorRunner {
+  private static final class DirectBufferRunner implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -213,7 +213,7 @@ public int compare(final byte[] o1, final byte[] o2) {
   /**
    * Tests using Guava's {@link SignedBytes} comparator.
    */
-  private static class GuavaSignedBytes implements ComparatorRunner {
+  private static final class GuavaSignedBytes implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -225,7 +225,7 @@ public int compare(final byte[] o1, final byte[] o2) {
   /**
    * Tests using Guava's {@link UnsignedBytes} comparator.
    */
-  private static class GuavaUnsignedBytes implements ComparatorRunner {
+  private static final class GuavaUnsignedBytes implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -237,7 +237,7 @@ public int compare(final byte[] o1, final byte[] o2) {
   /**
    * Tests {@link ByteBufProxy}.
    */
-  private static class NettyRunner implements ComparatorRunner {
+  private static final class NettyRunner implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
@@ -254,7 +254,7 @@ public int compare(final byte[] o1, final byte[] o2) {
    * Tests {@link String} by providing a reference implementation of what a
    * comparator involving ASCII-encoded bytes should return.
    */
-  private static class StringRunner implements ComparatorRunner {
+  private static final class StringRunner implements ComparatorRunner {
 
     @Override
     public int compare(final byte[] o1, final byte[] o2) {
diff --git a/src/test/java/org/lmdbjava/KeyRangeTest.java b/src/test/java/org/lmdbjava/KeyRangeTest.java
@@ -233,7 +233,7 @@ private void verify(final KeyRange<Integer> range, final int... expected) {
    * We use <code>Integer</code> rather than the primitive to represent a
    * <code>null</code> buffer.
    */
-  private static class FakeCursor {
+  private static final class FakeCursor {
 
     private static final int[] KEYS = new int[]{2, 4, 6, 8};
     private int position;
