Add tests for XxxFlags.isSet

at055612 · at055612 · commit 1312e102ec34 · 2025-11-17T13:03:52.000Z
diff --git a/src/test/java/org/lmdbjava/CopyFlagSetTest.java b/src/test/java/org/lmdbjava/CopyFlagSetTest.java
@@ -15,6 +15,8 @@
  */
 package org.lmdbjava;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.EnumSet;
@@ -72,4 +74,17 @@ Class<CopyFlags> getFlagType() {
   Function<EnumSet<CopyFlags>, CopyFlagSet> getConstructor() {
     return CopyFlagSetImpl::new;
   }
+
+  /**
+   * {@link FlagSet#isSet(MaskedFlag)} on the flag enum is tested in {@link AbstractFlagSetTest} but the coverage check
+   * doesn't seem to notice it.
+   */
+  @Test
+  void testIsSet() {
+    assertThat(CopyFlags.MDB_CP_COMPACT.isSet(CopyFlags.MDB_CP_COMPACT))
+        .isTrue();
+    //noinspection ConstantValue
+    assertThat(CopyFlags.MDB_CP_COMPACT.isSet(null))
+        .isFalse();
+  }
 }
diff --git a/src/test/java/org/lmdbjava/DbiFlagSetTest.java b/src/test/java/org/lmdbjava/DbiFlagSetTest.java
@@ -15,6 +15,8 @@
  */
 package org.lmdbjava;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.EnumSet;
@@ -72,4 +74,19 @@ DbiFlagSet getFlagSet(DbiFlags flag) {
   Function<EnumSet<DbiFlags>, DbiFlagSet> getConstructor() {
     return DbiFlagSetImpl::new;
   }
+
+  /**
+   * {@link FlagSet#isSet(MaskedFlag)} on the flag enum is tested in {@link AbstractFlagSetTest} but the coverage check
+   * doesn't seem to notice it.
+   */
+  @Test
+  void testIsSet() {
+    assertThat(DbiFlags.MDB_CREATE.isSet(DbiFlags.MDB_CREATE))
+        .isTrue();
+    assertThat(DbiFlags.MDB_CREATE.isSet(DbiFlags.MDB_REVERSEKEY))
+        .isFalse();
+    //noinspection ConstantValue
+    assertThat(DbiFlags.MDB_CREATE.isSet(null))
+        .isFalse();
+  }
 }
diff --git a/src/test/java/org/lmdbjava/EnvFlagSetTest.java b/src/test/java/org/lmdbjava/EnvFlagSetTest.java
@@ -15,6 +15,8 @@
  */
 package org.lmdbjava;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.EnumSet;
@@ -72,4 +74,19 @@ Class<EnvFlags> getFlagType() {
   Function<EnumSet<EnvFlags>, EnvFlagSet> getConstructor() {
     return EnvFlagSetImpl::new;
   }
+
+  /**
+   * {@link FlagSet#isSet(MaskedFlag)} on the flag enum is tested in {@link AbstractFlagSetTest} but the coverage check
+   * doesn't seem to notice it.
+   */
+  @Test
+  void testIsSet() {
+    assertThat(EnvFlags.MDB_RDONLY_ENV.isSet(EnvFlags.MDB_RDONLY_ENV))
+        .isTrue();
+    assertThat(EnvFlags.MDB_RDONLY_ENV.isSet(EnvFlags.MDB_WRITEMAP))
+        .isFalse();
+    //noinspection ConstantValue
+    assertThat(EnvFlags.MDB_RDONLY_ENV.isSet(null))
+        .isFalse();
+  }
 }
diff --git a/src/test/java/org/lmdbjava/PutFlagSetTest.java b/src/test/java/org/lmdbjava/PutFlagSetTest.java
@@ -15,6 +15,8 @@
  */
 package org.lmdbjava;
 
+import static org.assertj.core.api.Assertions.assertThat;
+
 import java.time.Duration;
 import java.time.Instant;
 import java.util.Arrays;
@@ -76,6 +78,21 @@ Function<EnumSet<PutFlags>, PutFlagSet> getConstructor() {
     return PutFlagSetImpl::new;
   }
 
+  /**
+   * {@link FlagSet#isSet(MaskedFlag)} on the flag enum is tested in {@link AbstractFlagSetTest} but the coverage check
+   * doesn't seem to notice it.
+   */
+  @Test
+  void testIsSet() {
+    assertThat(PutFlags.MDB_APPEND.isSet(PutFlags.MDB_APPEND))
+        .isTrue();
+    assertThat(PutFlags.MDB_APPEND.isSet(PutFlags.MDB_MULTIPLE))
+        .isFalse();
+    //noinspection ConstantValue
+    assertThat(PutFlags.MDB_APPEND.isSet(null))
+        .isFalse();
+  }
+
   @Test
   public void testAddFlagVsCheckPresence() {
 
diff --git a/src/test/java/org/lmdbjava/TxnFlagSetTest.java b/src/test/java/org/lmdbjava/TxnFlagSetTest.java
@@ -15,13 +15,15 @@
  */
 package org.lmdbjava;
 
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.lmdbjava.TxnFlags.MDB_RDONLY_TXN;
+
 import java.util.Arrays;
 import java.util.Collection;
 import java.util.EnumSet;
 import java.util.List;
 import java.util.function.Function;
 import java.util.stream.Collectors;
-import org.assertj.core.api.Assertions;
 import org.junit.jupiter.api.Test;
 
 class TxnFlagSetTest extends AbstractFlagSetTest<TxnFlags, TxnFlagSet> {
@@ -30,7 +32,7 @@ class TxnFlagSetTest extends AbstractFlagSetTest<TxnFlags, TxnFlagSet> {
   void test() {
     // This is here purely to stop CodeQL moaning that this class is unused.
     // All the actual tests are in the superclass
-    Assertions.assertThat(getAllFlags()).isNotNull();
+    assertThat(getAllFlags()).isNotNull();
   }
 
   @Override
@@ -72,4 +74,17 @@ Class<TxnFlags> getFlagType() {
   Function<EnumSet<TxnFlags>, TxnFlagSet> getConstructor() {
     return TxnFlagSetImpl::new;
   }
+
+  /**
+   * {@link FlagSet#isSet(MaskedFlag)} on the flag enum is tested in {@link AbstractFlagSetTest} but the coverage check
+   * doesn't seem to notice it.
+   */
+  @Test
+  void testIsSet() {
+    assertThat(MDB_RDONLY_TXN.isSet(MDB_RDONLY_TXN))
+        .isTrue();
+    //noinspection ConstantValue
+    assertThat(MDB_RDONLY_TXN.isSet(null))
+        .isFalse();
+  }
 }
