Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: livelink/solid-queue-benchmark
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: livelink/solid-queue-benchmark
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: feat/add-support-for-postgres
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 20 commits
  • 26 files changed
  • 3 contributors

Commits on Jul 10, 2026

  1. docs: add spec for postgres support

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    19360fd View commit details
    Browse the repository at this point in the history

  2. docs: address spec review feedback on postgres support design

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    06f27be View commit details
    Browse the repository at this point in the history

  3. docs: add implementation plan for postgres support

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    dd239a1 View commit details
    Browse the repository at this point in the history

  4. feat: add PostgresClient mirroring MysqlClient

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    8f79adb View commit details
    Browse the repository at this point in the history

  5. feat: add Engines registry for per-engine facts

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    413f22f View commit details
    Browse the repository at this point in the history

  6. refactor: rename Profile's mysql_cpus/mysql_memory to db_cpus/db_memory

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    6e9c04e View commit details
    Browse the repository at this point in the history

  7. refactor: inject Digests SQL via constructor instead of hardcoding MySQL

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    2c8df67 View commit details
    Browse the repository at this point in the history

  8. feat: add database field to Result

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    09cdc2c View commit details
    Browse the repository at this point in the history

  9. feat: wire Runner to the selected database engine

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    23c4bc3 View commit details
    Browse the repository at this point in the history

  10. feat: add --database flag and rename --mysql-cpus/--mysql-memory to -… 

    …-db-cpus/--db-memory

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
    @MrLukeSmith @claude
    MrLukeSmith and claude committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    3c04325 View commit details
    Browse the repository at this point in the history

  11. feat: show database engine in compare reports; rename mysql_cpu to db… 

    …_cpu

Comparing a mysql result against a postgres result no longer trips the
ProfileMismatch guard (that guard only checks topology/resource fields).
The Database row is purely informational.
    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    304aabc View commit details
    Browse the repository at this point in the history

  12. feat: add postgres service to docker-compose.yml

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    3cdc6bb View commit details
    Browse the repository at this point in the history

  13. feat: select database adapter via BENCH_DATABASE

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    1d4862d View commit details
    Browse the repository at this point in the history

  14. feat: add pg gem for Postgres adapter support

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    2b739b2 View commit details
    Browse the repository at this point in the history

  15. feat: make db_setup adapter-aware for Postgres

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    e4d515d View commit details
    Browse the repository at this point in the history

  16. docs: document postgres support in README and mise tasks

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    0ea5550 View commit details
    Browse the repository at this point in the history

  17. fix: cast total_exec_time to numeric for Postgres ROUND 

    Postgres has no ROUND(double precision, integer) overload, only
ROUND(numeric, integer) - discovered via Task 14's manual Postgres
smoke run, which failed with 'function round(double precision,
integer) does not exist' when fetching top statement digests.
    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    d87a056 View commit details
    Browse the repository at this point in the history

  18. fix: parse psql output as CSV instead of naive newline/tab split 

    pg_stat_statements' query text can span multiple lines (e.g. Rails'
own multi-line schema-introspection queries), which a bare
newline-per-row split shreds into bogus extra rows with empty
columns - discovered via Task 14's manual Postgres smoke run, whose
top_statements output was garbage. psql's --csv mode quotes
multi-line fields per RFC4180, so Ruby's CSV library parses them
correctly.
    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    56c2e68 View commit details
    Browse the repository at this point in the history

  19. test: guard the Postgres ROUND numeric-cast regression 

    Cheap insurance recommended by the final whole-feature review - this
bug was only caught by a live Postgres run; without this assertion,
reverting the ::numeric cast would stay green in the unit suite.
    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    0bbb1a0 View commit details
    Browse the repository at this point in the history

  20. fix: avoid macos postgres fork crashes

    @MrLukeSmith
    MrLukeSmith committed Jul 10, 2026
    Configuration menu
    Copy the full SHA
    92bdf30 View commit details
    Browse the repository at this point in the history
Loading