From 281650ac107f7d17455569fd0076fb027bee3aba Mon Sep 17 00:00:00 2001 From: Mark Waddingham Date: Tue, 4 Apr 2017 16:50:25 +0000 Subject: [PATCH 1/2] [[ Bug ]] Ensure invisiblehwnd is destroyed on ~MCScreenDC This patch ensures that the invisiblehwnd which is created on windows is deleted when MCScreenDC is destroyed. --- engine/src/w32dcs.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/engine/src/w32dcs.cpp b/engine/src/w32dcs.cpp index a6b20bb4260..efdbf6a09ea 100644 --- a/engine/src/w32dcs.cpp +++ b/engine/src/w32dcs.cpp @@ -312,6 +312,9 @@ Boolean MCScreenDC::close(Boolean force) timeEndPeriod(1); opened = 0; + DestroyWindow(invisiblehwnd); + invisiblehwnd = NULL; + return True; } From 2c517f87e62bcfc753948fdb133118e0d1bf0bd7 Mon Sep 17 00:00:00 2001 From: Mark Waddingham Date: Tue, 4 Apr 2017 16:53:11 +0000 Subject: [PATCH 2/2] [[ Foundation ]] Correct implementation of MCHandlerTryToInvoke This patch ensures that the inout parameter list argument is untouched if an error is returned. --- libfoundation/src/foundation-handler.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/libfoundation/src/foundation-handler.cpp b/libfoundation/src/foundation-handler.cpp index 1e1895c7a04..4f47c2ccfbd 100644 --- a/libfoundation/src/foundation-handler.cpp +++ b/libfoundation/src/foundation-handler.cpp @@ -83,8 +83,6 @@ MCErrorRef MCHandlerTryToInvokeWithList(MCHandlerRef self, MCProperListRef& x_ar return nil; error_exit: - MCValueRelease(x_arguments); - x_arguments = nil; r_value = nil; MCErrorRef t_error;