[[ Bug 16323 ]] Make sure syntax variable is reset for each docs element

livecodeali · livecodeali · commit fc1186e61d12 · 2015-11-01T20:27:59.000Z
diff --git a/docs/notes/bugfix-16323.md b/docs/notes/bugfix-16323.md
@@ -0,0 +1 @@
+# Syntax is not being cleared between docs 'message' entries
diff --git a/ide-support/revdocsparser.livecodescript b/ide-support/revdocsparser.livecodescript
@@ -765,6 +765,7 @@ function revDocsFormatInlineComments pDataA, pIsLibrary
    repeat with x = tStart to tEnd
       put empty into tHasA
       put empty into tEntryDoc
+      put empty into tSyntax
       put tEntriesA[x] into tEntryA
       repeat with y = 1 to the number of elements in tEntryA["elements"]
          put tEntryA["elements"][y] into tElementA
@@ -858,8 +859,8 @@ function revDocsFormatInlineComments pDataA, pIsLibrary
       if tHasA["Syntax"] is not true then
          put pDataA["syntax"] into tSyntax
       end if
-      repeat with x = 1 to the number of elements in tSyntax
-         put "Syntax:" && tSyntax[x] & return & return before tEntryDoc
+      repeat with z = 1 to the number of elements in tSyntax
+         put "Syntax:" && tSyntax[z] & return & return before tEntryDoc
       end repeat
       
       if tHasA["Type"] is not true then
diff --git a/tests/lcs/docs/docsparser.livecodescript b/tests/lcs/docs/docsparser.livecodescript
@@ -0,0 +1,44 @@
+script "DocsParser"
+/*
+Copyright (C) 2015 LiveCode Ltd.
+
+This file is part of LiveCode.
+
+LiveCode is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License v3 as published by the Free
+Software Foundation.
+
+LiveCode is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
+
+on TestSetup
+   local tDocsParser
+   put TestGetEngineRepositoryPath() & "/ide-support/revdocsparser.livecodescript" into tDocsParser
+   start using stack tDocsParser
+end TestSetup
+
+on TestBug16323
+   local tDoc
+   put "/*" into tDoc
+   put return & "Name: OnOpen" after tDoc
+   put return & "Type: message" after tDoc
+   put return & "Syntax: OnOpen" after tDoc
+   put return & "Name: OnClose" after tDoc
+   put return & "Type: message" after tDoc
+   put return & "Syntax: OnClose" after tDoc
+   put return & "*/" after tDoc
+   put return & "module com.livecode.widget" after tDoc
+
+   local tParsed
+   put revDocsGenerateDocsFileFromText(tDoc, "") into tParsed
+
+   local tArray
+   put revDocsParseDocTextToLibraryArray("", tVar, "", "") into tArray
+
+   TestAssert "unwanted syntax element accumulation", tArray["doc"][2]["Syntax"][2] is empty
+end TestBug16323

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Syntax is not being cleared between docs 'message' entries`