[ CID 26001 ] Resource leak due to not returning the copied cstring.

runrevmark · runrevmark · commit f849a8222820 · 2015-02-11T09:14:15.000Z
diff --git a/libscript/src/module-foreign.cpp b/libscript/src/module-foreign.cpp
@@ -65,6 +65,8 @@ static bool __cstring_copy(void *from, void *to)
     
     MCMemoryCopy(t_new_string, from, t_length);
     
+    *(char **)to = t_new_string;
+    
     return true;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -65,6 +65,8 @@ static bool __cstring_copy(void from, void to)`
`65`	`65`
`66`	`66`	`MCMemoryCopy(t_new_string, from, t_length);`
`67`	`67`
	`68`	`+ (char *)to = t_new_string;`
	`69`	`+`
`68`	`70`	`return true;`
`69`	`71`	`}`
`70`	`72`