[[ Bug 13103 ]] Menu items starting with '-', with more content, should not generate a menu separator

livecodesebastien · livecodesebastien · commit d70f7968b402 · 2014-08-05T10:54:52.000+01:00
diff --git a/docs/notes/bugfix-13103.md b/docs/notes/bugfix-13103.md
@@ -0,0 +1 @@
+#option, pulldown and popUp menus don't accept negative numbers
diff --git a/engine/src/desktop-menu.cpp b/engine/src/desktop-menu.cpp
@@ -266,7 +266,9 @@ class MCMenuBuilderCallback: public IParseMenuCallback
         if (!t_utf_title . Lock(p_menuitem -> label))
             return false;
 		
-		if (MCStringGetCharAtIndex(p_menuitem -> label, 0) == '-')
+        // SN-2014-08-05: [[ Bug 13103 ]] The item label must be "-" to be a menu separator,
+        //  not only start with '-'
+		if (MCStringIsEqualToCString(p_menuitem -> label, "-", kMCStringOptionCompareExact))
 			MCPlatformAddMenuSeparatorItem(TopMenu(), UINDEX_MAX);
 		else
 		{

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+#option, pulldown and popUp menus don't accept negative numbers`