[[ Cleanup ]] Rename MCNameLookup to MCNameLookupCaseless

runrevmark · runrevmark · commit b46fc55f641c · 2017-09-06T12:18:00.000+01:00
This patch renames the MCNameLookup function to MCNameLookupCaseless
to make it clearer what the function is doing.
diff --git a/engine/src/exec-interface-group.cpp b/engine/src/exec-interface-group.cpp
@@ -259,7 +259,7 @@ void MCGroup::SetHilitedButtonName(MCExecContext& ctxt, uint32_t part, MCStringR
                 // Clicking on the button attemps to hilite the option "title,menu,maximize,minimise,close"
                 // but only "title,menu,minimize,maximise,close" exists, returning a nil NameRef
                 MCNameRef t_nameref;
-                t_nameref = MCNameLookup(p_name);
+                t_nameref = MCNameLookupCaseless(p_name);
                 if (t_nameref != nil)
                     bptr->resethilite(part, bptr->hasname(t_nameref));
                 else
diff --git a/engine/src/exec-interface-stack.cpp b/engine/src/exec-interface-stack.cpp
@@ -1170,7 +1170,7 @@ void MCStack::SetSubstacks(MCExecContext& ctxt, MCStringRef p_substacks)
 			{
 				// Lookup 't_name_string' as a name, if it doesn't exist it can't exist as a substack
 				// name.
-				&t_name = MCValueRetain(MCNameLookup(*t_name_string));
+				&t_name = MCValueRetain(MCNameLookupCaseless(*t_name_string));
 				if (*t_name != nil)
 				{
 					while (tsub -> hasname(*t_name))
diff --git a/engine/src/exec-multimedia.cpp b/engine/src/exec-multimedia.cpp
@@ -575,7 +575,7 @@ static MCPlayer* MCMultimediaExecGetClip(MCExecContext& ctxt, MCStringRef p_clip
 	if (p_chunk_type == CT_EXPRESSION)
 	{
         // AL-2014-05-27: [[ Bug 12517 ]] MCNameLookup does not increase the ref count
-		return MCPlayer::FindPlayerByName(MCNameLookup(p_clip));
+		return MCPlayer::FindPlayerByName(MCNameLookupCaseless(p_clip));
 	}
 	
     if (p_chunk_type == CT_ID)
diff --git a/engine/src/foundation-legacy.cpp b/engine/src/foundation-legacy.cpp
@@ -1150,7 +1150,7 @@ MCNameRef MCNameLookupWithCString(const char *cstring, MCCompareOptions options)
 		return nil;
 
 	MCNameRef t_name;
-	t_name = MCNameLookup(t_string);
+	t_name = MCNameLookupCaseless(t_string);
 	MCValueRelease(t_string);
 
 	return t_name;
@@ -1163,7 +1163,7 @@ MCNameRef MCNameLookupWithOldString(const MCString& string, MCCompareOptions opt
 		return nil;
 
 	MCNameRef t_name;
-	t_name = MCNameLookup(t_string);
+	t_name = MCNameLookupCaseless(t_string);
 	MCValueRelease(t_string);
 
 	return t_name;
diff --git a/engine/src/stack3.cpp b/engine/src/stack3.cpp
@@ -799,7 +799,7 @@ Exec_stat MCStack::resubstack(MCStringRef p_data)
 			// If t_val doesn't exist as a name, it can't exist as a substack name.
 			// t_val is always a stringref (fetched from an MCSplitString array)
 			MCNameRef t_name;
-			t_name = MCNameLookup((MCStringRef)t_val);
+			t_name = MCNameLookupCaseless((MCStringRef)t_val);
 		
 			if (t_name != nil)
 				while (tsub -> hasname(t_name))
diff --git a/libfoundation/include/foundation.h b/libfoundation/include/foundation.h
@@ -2050,7 +2050,7 @@ MC_DLLEXPORT bool MCNameCreateWithNativeChars(const char_t *chars, uindex_t coun
 MC_DLLEXPORT bool MCNameCreateAndRelease(MCStringRef string, MCNameRef& r_name);
 
 // Looks for an existing name matching the given string.
-MC_DLLEXPORT MCNameRef MCNameLookup(MCStringRef string);
+MC_DLLEXPORT MCNameRef MCNameLookupCaseless(MCStringRef string);
 
 // Returns a unsigned integer which can be used to order a table for a binary
 // search.
diff --git a/libfoundation/src/foundation-name.cpp b/libfoundation/src/foundation-name.cpp
@@ -206,7 +206,7 @@ bool MCNameCreateAndRelease(MCStringRef p_string, MCNameRef& r_name)
 }
 
 MC_DLLEXPORT_DEF
-MCNameRef MCNameLookup(MCStringRef p_string)
+MCNameRef MCNameLookupCaseless(MCStringRef p_string)
 {
 	// Compute the hash of the characters, up to case.
 	hash_t t_hash;

Original file line number	Diff line number	Diff line change
`@@ -1170,7 +1170,7 @@ void MCStack::SetSubstacks(MCExecContext& ctxt, MCStringRef p_substacks)`
`1170`	`1170`	`{`
`1171`	`1171`	`// Lookup 't_name_string' as a name, if it doesn't exist it can't exist as a substack`
`1172`	`1172`	`// name.`
`1173`		`- &t_name = MCValueRetain(MCNameLookup(*t_name_string));`
	`1173`	`+ &t_name = MCValueRetain(MCNameLookupCaseless(*t_name_string));`
`1174`	`1174`	`if (*t_name != nil)`
`1175`	`1175`	`{`
`1176`	`1176`	`while (tsub -> hasname(*t_name))`
Original file line number	Diff line number	Diff line change
`@@ -575,7 +575,7 @@ static MCPlayer* MCMultimediaExecGetClip(MCExecContext& ctxt, MCStringRef p_clip`
`575`	`575`	`if (p_chunk_type == CT_EXPRESSION)`
`576`	`576`	`{`
`577`	`577`	`// AL-2014-05-27: [[ Bug 12517 ]] MCNameLookup does not increase the ref count`
`578`		`- return MCPlayer::FindPlayerByName(MCNameLookup(p_clip));`
	`578`	`+ return MCPlayer::FindPlayerByName(MCNameLookupCaseless(p_clip));`
`579`	`579`	`}`
`580`	`580`
`581`	`581`	`if (p_chunk_type == CT_ID)`
Original file line number	Diff line number	Diff line change
`@@ -206,7 +206,7 @@ bool MCNameCreateAndRelease(MCStringRef p_string, MCNameRef& r_name)`
`206`	`206`	`}`
`207`	`207`
`208`	`208`	`MC_DLLEXPORT_DEF`
`209`		`-MCNameRef MCNameLookup(MCStringRef p_string)`
	`209`	`+MCNameRef MCNameLookupCaseless(MCStringRef p_string)`
`210`	`210`	`{`
`211`	`211`	`// Compute the hash of the characters, up to case.`
`212`	`212`	`hash_t t_hash;`