[[ Bug 14413 ]] Fix wrong if statement

livecodesebastien · livecodesebastien · commit 9a7d3a339039 · 2015-03-13T11:16:39.000Z
diff --git a/revzip/src/revzip.cpp b/revzip/src/revzip.cpp
@@ -1280,7 +1280,7 @@ void revZipEnumerateItems(char *p_arguments[], int p_argument_count, char **r_re
 			else
 			{
 				char *t_converted_name;
-				int t_success;
+                int t_success;
 
 				// SN-2015-03-10: [[ Bug 14413 ]] We convert the string to UTF-8
 				//  in case it was natively encoded, as revZipEnumerateItems is
@@ -1291,9 +1291,9 @@ void revZipEnumerateItems(char *p_arguments[], int p_argument_count, char **r_re
 					t_converted_name = strdup(t_stat.name);
 				}
 				else
-					t_converted_name = ConvertCStringFromNativeToUTF8(t_stat.name, &t_success);
+                    t_converted_name = ConvertCStringFromNativeToUTF8(t_stat.name, &t_success);
 
-				if (t_success)
+                if (t_success == EXTERNAL_SUCCESS)
 				{
 					t_str_names += std::string(t_converted_name);
 					t_str_names += "\n";

Original file line number	Diff line number	Diff line change
`@@ -1280,7 +1280,7 @@ void revZipEnumerateItems(char p_arguments[], int p_argument_count, char *r_re`
`1280`	`1280`	`else`
`1281`	`1281`	`{`
`1282`	`1282`	`char *t_converted_name;`
`1283`		`- int t_success;`
	`1283`	`+ int t_success;`
`1284`	`1284`
`1285`	`1285`	`// SN-2015-03-10: [[ Bug 14413 ]] We convert the string to UTF-8`
`1286`	`1286`	`// in case it was natively encoded, as revZipEnumerateItems is`
`@@ -1291,9 +1291,9 @@ void revZipEnumerateItems(char p_arguments[], int p_argument_count, char *r_re`
`1291`	`1291`	`t_converted_name = strdup(t_stat.name);`
`1292`	`1292`	`}`
`1293`	`1293`	`else`
`1294`		`- t_converted_name = ConvertCStringFromNativeToUTF8(t_stat.name, &t_success);`
	`1294`	`+ t_converted_name = ConvertCStringFromNativeToUTF8(t_stat.name, &t_success);`
`1295`	`1295`
`1296`		`- if (t_success)`
	`1296`	`+ if (t_success == EXTERNAL_SUCCESS)`
`1297`	`1297`	`{`
`1298`	`1298`	`t_str_names += std::string(t_converted_name);`
`1299`	`1299`	`t_str_names += "\n";`