[[ Element Chunk ]] Only signal property listener on setting custom prop

livecodeali · livecodeali · commit 99aa92b7801e · 2016-01-20T17:03:29.000Z
diff --git a/engine/src/chunk.cpp b/engine/src/chunk.cpp
@@ -4577,14 +4577,13 @@ bool MCChunk::getsetcustomprop(MCExecContext &ctxt, MCNameRef p_prop_name, MCNam
         }
     }
     
-    if (t_success)
+    if (t_success && !p_is_get_operation)
     {
         // MM-2012-09-05: [[ Property Listener ]] Make sure setting a custom property sends propertyChanged message to listeners.
         t_object -> signallisteners(P_CUSTOM);
-        return true;
     }
     
-    return false;
+    return t_success;
 }
 
 bool MCChunk::getcustomprop(MCExecContext& ctxt, MCNameRef p_prop_name, MCNameRef p_index_name, MCExecValue& r_value)

Original file line number	Diff line number	Diff line change
`@@ -4577,14 +4577,13 @@ bool MCChunk::getsetcustomprop(MCExecContext &ctxt, MCNameRef p_prop_name, MCNam`
`4577`	`4577`	`}`
`4578`	`4578`	`}`
`4579`	`4579`
`4580`		`- if (t_success)`
	`4580`	`+ if (t_success && !p_is_get_operation)`
`4581`	`4581`	`{`
`4582`	`4582`	`// MM-2012-09-05: [[ Property Listener ]] Make sure setting a custom property sends propertyChanged message to listeners.`
`4583`	`4583`	`t_object -> signallisteners(P_CUSTOM);`
`4584`		`- return true;`
`4585`	`4584`	`}`
`4586`	`4585`
`4587`		`- return false;`
	`4586`	`+ return t_success;`
`4588`	`4587`	`}`
`4589`	`4588`
`4590`	`4589`	`bool MCChunk::getcustomprop(MCExecContext& ctxt, MCNameRef p_prop_name, MCNameRef p_index_name, MCExecValue& r_value)`