[[ Bug 20814 ]] Add release note and tests

livecodeali · livecodeali · commit 960cc2971240 · 2018-02-19T17:10:04.000Z
diff --git a/docs/notes/bugfix-20814.md b/docs/notes/bugfix-20814.md
@@ -0,0 +1 @@
+# Fix printing to pdf
diff --git a/engine/src/printer.h b/engine/src/printer.h
@@ -613,7 +613,7 @@ class MCCustomPrinter: public MCPrinter
 	MCArrayRef m_device_options;
 };
 
-Exec_stat MCCustomPrinterCreate(MCStringRef p_destination, MCStringRef p_filename, MCArrayRef p_options, MCCustomPrinter*& r_printer);
+bool MCCustomPrinterCreate(MCStringRef p_destination, MCStringRef p_filename, MCArrayRef p_options, MCCustomPrinter*& r_printer);
 
 ////////////////////////////////////////////////////////////////////////////////
 
diff --git a/tests/_testlib.livecodescript b/tests/_testlib.livecodescript
@@ -487,7 +487,7 @@ on TestLoadAuxiliaryExtension pName, pResourceFolder
    end if
 end TestLoadAuxiliaryExtension
 
-constant kBytecodePathPrefix = "_tests/_build/"
+constant kTestsBuildPath = "_tests/_build/"
 function TestGetBuiltBytecodeFile pName
    local tBasePath, tExtraPath
    set the itemDelimiter to slash
@@ -501,11 +501,15 @@ function TestGetBuiltBytecodeFile pName
    put item 1 to tTestsOffset - 1 of tBasePath into tBasePath
    
    local tModuleFile
-   put tBasePath & "/" & kBytecodePathPrefix & tExtraPath & slash & \ 
+   put tBasePath & "/" & kTestsBuildPath & tExtraPath & slash & \ 
       pName & ".lcm" into tModuleFile
    return tModuleFile
 end TestGetBuiltBytecodeFile
 
+function TestGetTestBuildFolder
+	return TestGetEngineRepositoryPath() & slash & kTestsBuildPath
+end TestGetTestBuildFolder
+
 on TestLoadAllExtensions
    local tExtFolder
    put _TestGetBuiltExtensionsFolder() into tExtFolder
diff --git a/tests/lcs/core/printing/printing.livecodescript b/tests/lcs/core/printing/printing.livecodescript
@@ -0,0 +1,42 @@
+script "CorePrinting"
+/*
+Copyright (C) 2018 LiveCode Ltd.
+
+This file is part of LiveCode.
+
+LiveCode is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License v3 as published by the Free
+Software Foundation.
+
+LiveCode is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with LiveCode.  If not see <http://www.gnu.org/licenses/>.  */
+
+on TestPDFPrinter
+   TestSkipIfNot "external", "revpdfprinter"
+   
+   local tFile, tStack
+   put TestGetTestBuildFolder() & slash & "test.pdf" into tFile
+   create stack
+   put it into tStack
+   open printing to pdf tFile
+   print card 1 of tStack
+   close printing
+   TestAssert "print stack to pdf", there is a file tFile
+end TestPDFPrinter
+
+command _TestOpenPrintingBadDest
+   local tFile
+   put TestGetTestBuildFolder() & slash & "test" into tFile
+   open printing to baddest tFile
+end _TestOpenPrintingBadDest
+
+on TestOpenPrintingBadDest
+   TestAssertThrow "open printing to bad dest throws", \
+      _TestOpenPrintingBadDest, the long id of me, \
+      EE_PRINT_UNKNOWNDST
+end TestOpenPrintingBadDest
