[Bug 18042] Fix special character escaping in guide PDF

peter-b · peter-b · commit 93439b572375 · 2016-08-02T17:52:11.000+01:00
The HTML template for generating the User Guide PDF overrode the
`marked.js` built-in functions for rendering code sections.  This
meant that `&lt;` and `&gt;` characters in MarkDown code blocks were
appearing literally in the output HTML.  Among other problems, this
gave the User Guide PDF the very surprising title of `"
theDataA[theIndex]["Title"] &amp; "`, thanks to an example in the Data
Grid guide!
diff --git a/builder/user-guide-template.html b/builder/user-guide-template.html
@@ -753,16 +753,6 @@
 				img_no_pg_break += '&nbsp;</div>';
 				return img_no_pg_break;
 			}
-		
-			renderer.code = function (code, language, callback)
-			{
-				return '<pre><code>' + code + '</code></pre>';
-			}
-			
-			renderer.codespan = function (code)
-			{
-				return '<code class="inline">' + code + '</code>';
-			}
 			
 			var content_html = marked(prefix, { renderer: renderer });
 
diff --git a/docs/notes/bugfix-18042.md b/docs/notes/bugfix-18042.md
@@ -0,0 +1 @@
+# Ensure guide PDF escapes special characters correctly.

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure guide PDF escapes special characters correctly.`