Used !MCStringIsEmpty instead of MCStringGetLength to take care of null

livecodepanos · livecodepanos · commit 9266147a82c0 · 2018-09-19T12:39:15.000+03:00
diff --git a/engine/src/dskmac.cpp b/engine/src/dskmac.cpp
@@ -5530,7 +5530,7 @@ static void MCS_startprocess_launch(MCNameRef name, MCStringRef docname, Open_mo
 		FSRef launchedapp;
 		inLaunchSpec.numDocs = 0;
 		inLaunchSpec.itemRefs = NULL;
-		if (MCStringGetLength(docname))
+		if (!MCStringIsEmpty(docname))
 		{
 			if (MCS_mac_pathtoref(docname, t_doc_fsref) != noErr)
 			{
@@ -5549,7 +5549,7 @@ static void MCS_startprocess_launch(MCNameRef name, MCStringRef docname, Open_mo
 	}
     
 	errno = connectionInvalid;
-	if (MCStringGetLength(docname))
+	if (!MCStringIsEmpty(docname))
 	{
 		for (i = 0 ; i < MCnprocesses ; i++)
 			if (MCNameIsEqualTo(name, MCprocesses[i].name, kMCStringOptionCompareExact))
diff --git a/engine/src/exec-files.cpp b/engine/src/exec-files.cpp
@@ -864,7 +864,7 @@ void MCFilesExecPerformOpenProcess(MCExecContext& ctxt, MCNameRef p_process, int
 		ctxt . SetTheResultToStaticCString("process is already open");
 		return;
 	}
-    MCS_startprocess(p_process, kMCEmptyString, (Open_mode)p_mode, p_elevated);
+    MCS_startprocess(p_process, NULL, (Open_mode)p_mode, p_elevated);
 	if (IO_findprocess(p_process, index))
     {
         // ENCODING what default encoding for the process?

Original file line number	Diff line number	Diff line change
`@@ -5530,7 +5530,7 @@ static void MCS_startprocess_launch(MCNameRef name, MCStringRef docname, Open_mo`
`5530`	`5530`	`FSRef launchedapp;`
`5531`	`5531`	`inLaunchSpec.numDocs = 0;`
`5532`	`5532`	`inLaunchSpec.itemRefs = NULL;`
`5533`		`- if (MCStringGetLength(docname))`
	`5533`	`+ if (!MCStringIsEmpty(docname))`
`5534`	`5534`	`{`
`5535`	`5535`	`if (MCS_mac_pathtoref(docname, t_doc_fsref) != noErr)`
`5536`	`5536`	`{`
`@@ -5549,7 +5549,7 @@ static void MCS_startprocess_launch(MCNameRef name, MCStringRef docname, Open_mo`
`5549`	`5549`	`}`
`5550`	`5550`
`5551`	`5551`	`errno = connectionInvalid;`
`5552`		`- if (MCStringGetLength(docname))`
	`5552`	`+ if (!MCStringIsEmpty(docname))`
`5553`	`5553`	`{`
`5554`	`5554`	`for (i = 0 ; i < MCnprocesses ; i++)`
`5555`	`5555`	`if (MCNameIsEqualTo(name, MCprocesses[i].name, kMCStringOptionCompareExact))`
Original file line number	Diff line number	Diff line change
`@@ -864,7 +864,7 @@ void MCFilesExecPerformOpenProcess(MCExecContext& ctxt, MCNameRef p_process, int`
`864`	`864`	`ctxt . SetTheResultToStaticCString("process is already open");`
`865`	`865`	`return;`
`866`	`866`	`}`
`867`		`- MCS_startprocess(p_process, kMCEmptyString, (Open_mode)p_mode, p_elevated);`
	`867`	`+ MCS_startprocess(p_process, NULL, (Open_mode)p_mode, p_elevated);`
`868`	`868`	`if (IO_findprocess(p_process, index))`
`869`	`869`	`{`
`870`	`870`	`// ENCODING what default encoding for the process?`