[[ Bug 12419 ]] Ensure Android ScrollViews don't cancel touch events

montegoulding · montegoulding · commit 63bc5f4ab9fc · 2019-04-03T19:42:41.000+11:00
This patch implements the `onInterceptTouchEvent` method in the vertical and
horizontal scroll views so that they do not cancel the touch events. Without
this patch the cancellation of the touch events causes a touch down to be unpaired
with an up or release event. Not that iOS Scrollers have a `canCancelTouches`
property but android scrollers do not.
diff --git a/docs/notes/bugfix-12419.md b/docs/notes/bugfix-12419.md
@@ -0,0 +1 @@
+# Fix touch messages not being sent to controls under an mobile scroller control on Android
diff --git a/engine/src/java/com/runrev/android/nativecontrol/ScrollerControl.java b/engine/src/java/com/runrev/android/nativecontrol/ScrollerControl.java
@@ -80,6 +80,12 @@ public void onScrollChanged(int l, int t, int oldl, int oldt)
                     ScrollerControl.this.updateScroll(m_dispatching ? m_new_left : m_left, t);
                 super.onScrollChanged(l, t, oldl, oldt);
             }
+            
+            @Override
+            public boolean onInterceptTouchEvent (MotionEvent ev)
+            {
+                return true;
+            }
         };
         m_hscroll = new HorizontalScrollView(p_context) {
             @Override
@@ -89,6 +95,12 @@ public void onScrollChanged(int l, int t, int oldl, int oldt)
                     ScrollerControl.this.updateScroll(l, m_dispatching ? m_new_top : m_top);
                 super.onScrollChanged(l, t, oldl, oldt);
             }
+            
+            @Override
+            public boolean onInterceptTouchEvent (MotionEvent ev)
+            {
+                return true;
+            }
         };
         
         m_inner_hview = new View(p_context) {

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix touch messages not being sent to controls under an mobile scroller control on Android`