[[ Bug 21532 ]] Remove AutoLock from AddTextToItem

montegoulding · montegoulding · commit 6227ade0154f · 2018-09-04T08:29:32.000+10:00
This patch removes the `AutoLock` from `AddTextToItem` so that there
is no pull and push after the item has been created. `AddTextToItem`
is a convenience method that should be called on a locked clipboard
that has any external data cleared.
diff --git a/engine/src/clipboard.cpp b/engine/src/clipboard.cpp
@@ -276,8 +276,6 @@ bool MCClipboard::AddText(MCStringRef p_string)
 
 bool MCClipboard::AddTextToItem(MCRawClipboardItem* p_item, MCStringRef p_string)
 {
-    AutoLock t_lock(this);
-    
     // For each text encoding that the underlying clipboard supports, encode the
     // text and add it.
     bool t_success = true;

Original file line number	Diff line number	Diff line change
`@@ -276,8 +276,6 @@ bool MCClipboard::AddText(MCStringRef p_string)`
`276`	`276`
`277`	`277`	`bool MCClipboard::AddTextToItem(MCRawClipboardItem* p_item, MCStringRef p_string)`
`278`	`278`	`{`
`279`		`- AutoLock t_lock(this);`
`280`		`-`
`281`	`279`	`// For each text encoding that the underlying clipboard supports, encode the`
`282`	`280`	`// text and add it.`
`283`	`281`	`bool t_success = true;`