[[ Bug 17523 ]] Fix LCB property name parsing for docs

livecodeali · livecodeali · commit 5faf880244f3 · 2016-05-27T16:51:10.000+01:00
diff --git a/docs/notes/bugfix-17523.md b/docs/notes/bugfix-17523.md
@@ -0,0 +1 @@
+# Fix LCB docs builder handling of string-like property names
diff --git a/ide-support/revdocsparser.livecodescript b/ide-support/revdocsparser.livecodescript
@@ -1523,7 +1523,7 @@ end revDocsParseHandler
 
 on revDocsUpdateDocBlocksForProperty pData, pComment, @xDataA
    local tName
-   put word 2 of pData into tName
+   put token 1 to -1 of word 2 of pData into tName
    put pComment into xDataA[tName]["comments"]
    put "property" into xDataA[tName]["type"]
    put tName into xDataA[tName]["name"]
diff --git a/tests/lcs/docs/docsparser.livecodescript b/tests/lcs/docs/docsparser.livecodescript
@@ -38,12 +38,31 @@ on TestBug16323
    put return & "Syntax: OnClose" after tDoc
    put return & "*/" after tDoc
    put return & "module com.livecode.widget" after tDoc
+   put return & "end module" after tDoc
 
    local tParsed
    put revDocsGenerateDocsFileFromText(tDoc, "") into tParsed
 
    local tArray
-   put revDocsParseDocTextToLibraryArray("", tVar, "", "") into tArray
+   put revDocsParseDocTextToLibraryArray("", tParsed, "", "") into tArray
 
    TestAssert "unwanted syntax element accumulation", tArray["doc"][2]["Syntax"][2] is empty
 end TestBug16323
+
+on TestBug17523
+   local tModule
+   put "widget com.livecode.testdocs" into tModule
+   put return & "/**" after tModule
+   put return & "Summary: Test" after tModule
+   put return & "*/" after tModule
+   put return & "property" && quote & "testProp" & quote && "get mTest" after tModule
+   put return & "end widget" after tModule
+   
+   local tParsed
+   put revDocsGenerateDocsFileFromText(tModule, "") into tParsed
+   
+   local tArray
+   put revDocsParseDocTextToLibraryArray("", tParsed, "", "") into tArray
+   
+   TestAssert "property name has quotes stripped", tArray["doc"][1]["display name"] is "testProp"
+end TestBug17523

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Fix LCB docs builder handling of string-like property names`