[[ CID 117572 ]] Null pointer dereferences (FORWARD_NULL)

Monte Goulding · Monte Goulding · commit 57cac1cc8404 · 2015-10-13T10:37:47.000+11:00
diff --git a/lcidlc/src/Value.cpp b/lcidlc/src/Value.cpp
@@ -83,7 +83,8 @@ void ValueRelease(ValueRef self)
 			Value *t_name;
 			for(t_name = s_names; t_name != nil && t_name -> name . next != self; t_name = t_name -> name . next)
 				;
-			t_name -> name . next = self -> name . next;
+            if (t_name != nil)
+                t_name -> name . next = self -> name . next;
 		}
 		
 		ValueRelease(self -> name . string);

Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,8 @@ void ValueRelease(ValueRef self)`
`83`	`83`	`Value *t_name;`
`84`	`84`	`for(t_name = s_names; t_name != nil && t_name -> name . next != self; t_name = t_name -> name . next)`
`85`	`85`	`;`
`86`		`- t_name -> name . next = self -> name . next;`
	`86`	`+ if (t_name != nil)`
	`87`	`+ t_name -> name . next = self -> name . next;`
`87`	`88`	`}`
`88`	`89`
`89`	`90`	`ValueRelease(self -> name . string);`