[[ Bug 23176 ]] Ensure the target MacOS SDK (10.9) is properly set

livecodepanos · livecodepanos · commit 4f0e8e28b254 · 2021-05-03T11:58:12.000+03:00
This patch ensures that hardened runtime will not block externals from
launching. This happened because the target sdk version was not
set in the externals after building with Xcode12+.

Note: Xcode uses clang to drive ld - '-Wl', means pass this option to the linker direct
diff --git a/config/mac.gypi b/config/mac.gypi
@@ -30,7 +30,7 @@
 		'STRIP_INSTALLED_PRODUCT': 'NO',
 		'CLANG_LINK_OBJC_RUNTIME': 'NO',
 		'CLANG_CXX_LANGUAGE_STANDARD': 'c++11',
-        'CLANG_CXX_LIBRARY': 'libc++'
+		'CLANG_CXX_LIBRARY': 'libc++'
 	},
 	
 	'target_defaults':
@@ -47,6 +47,7 @@
 			'debug_info_suffix': '.dSYM',
 			
 			'silence_warnings': 0,
+			'travis': '<!(echo ${TRAVIS})',
 		},
 		
 		'target_conditions':
@@ -70,6 +71,21 @@
 					],
 				},
 			],
+			[
+				'travis == ""',
+				{
+					'xcode_settings':
+					{
+						'OTHER_LD_FLAGS':
+						[
+							'-Wl,-platform_version',
+							'-Wl,macos',
+							'-Wl,10.9',
+							'-Wl,10.9',
+						],
+					},
+				},
+			],
 			[
 				# Non-bundle loadable module should have a .dylib suffix
 				# and be linked as libraries, not bundles
diff --git a/docs/notes/bugfix-23176.md b/docs/notes/bugfix-23176.md
@@ -0,0 +1 @@
+# Ensure externals are not blocked by hardened runtime

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure externals are not blocked by hardened runtime`