revxml: Use free() to destroy attribute values

peter-b · peter-b · commit 2a9d800ccebe · 2017-01-24T12:54:20.000Z
Attribute value buffers are allocated with `strdup()`, and should
therefore be destroyed using `free()`, not `delete`.
diff --git a/revxml/src/revxml.cpp b/revxml/src/revxml.cpp
@@ -2182,7 +2182,7 @@ void XML_FindElementByAttributeValue(char *args[], int nargs, char **retstring,
 						else
 							t_comparison_result = util_strnicmp(attvalue, tvalue, strlen(tvalue));
                         
-                        delete tvalue;
+                        free(tvalue);
                         
                         if (t_comparison_result == 0)
                         {

Original file line number	Diff line number	Diff line change
`@@ -2182,7 +2182,7 @@ void XML_FindElementByAttributeValue(char args[], int nargs, char *retstring,`
`2182`	`2182`	`else`
`2183`	`2183`	`t_comparison_result = util_strnicmp(attvalue, tvalue, strlen(tvalue));`
`2184`	`2184`
`2185`		`- delete tvalue;`
	`2185`	`+ free(tvalue);`
`2186`	`2186`
`2187`	`2187`	`if (t_comparison_result == 0)`
`2188`	`2188`	`{`