[Symbolicator] Tweaks to support both old and new symbol names

livecodepanos · livecodepanos · commit 03930696d606 · 2017-11-29T14:27:04.000Z
diff --git a/tools/SymbolicatorScript.livecodescript b/tools/SymbolicatorScript.livecodescript
@@ -505,16 +505,43 @@ private command fetchSymbolsForRevision pOutputDir, pServerPath, pFullVersion, p
    replace space with "%20" in pFullVersion
    
    -- Generate the URL for the file containing the symbols
-   local tURL, tMacSymbolsZip
+   local tURL, tMacSymbolsZip, tCommitHashLength, tBuildNumber
+   
+   put char 7 to 11 of pFullVersion into tBuildNumber
    
    if pFullVersion begins with "8" then
-      put "universal-mac-macosx10.6-bin.tar.bz2" into tMacSymbolsZip
-   else
-      put "universal-mac-macosx10.9-bin.tar.bz2" into tMacSymbolsZip
+      
+      if tBuildNumber < 14023 then -- 8.0.0 until 8.1.3
+         put 7 into tCommitHashLength
+         put "mac-bin.tar.xz" into tMacSymbolsZip
+      else if tBuildNumber >= 14023 and tBuildNumber < 14035 then -- 8.1.4 RC-1 until 8.1.6
+         put 7 into tCommitHashLength
+         put "universal-mac-macosx10.6-bin.tar.bz2" into tMacSymbolsZip
+      else if tBuildNumber >= 14035 then -- 8.1.7 RC-1 +
+         put 10 into tCommitHashLength
+         put "universal-mac-macosx10.6-bin.tar.bz2" into tMacSymbolsZip
+      end if
+      
+   else -- pFullVersion begins with "9"
+      
+      if tBuildNumber < 15004 then -- DP-1 until DP-4
+         put 7 into tCommitHashLength
+         put "mac-bin.tar.xz" into tMacSymbolsZip
+      else if tBuildNumber is "15004" or tBuildNumber is "15005" then -- DP-5 and DP-6
+         put 7 into tCommitHashLength
+         put "mac-bin.tar.bz2" into tMacSymbolsZip
+      else if tBuildNumber is "15009" or tBuildNumber is "15010" then -- DP-7 and DP-8
+         put 7 into tCommitHashLength
+         put "universal-mac-macosx10.6-bin.tar.bz2" into tMacSymbolsZip
+      else if tBuildNumber >= 15012 then -- DP-9+
+         put 10 into tCommitHashLength
+         put "universal-mac-macosx10.6-bin.tar.bz2" into tMacSymbolsZip
+      end if
+      
    end if
    
-   put pServerPath & "/" & pFullVersion & "/g" & char 1 to 10 of pCommitHash & slash & tMacSymbolsZip into tURL
-      
+   put pServerPath & "/" & pFullVersion & "/g" & char 1 to tCommitHashLength of pCommitHash & slash & tMacSymbolsZip into tURL
+   
    -- Create the output folder, if required
    if there is not a folder pOutputDir then
       create folder pOutputDir
