Skip to content

Commit db1806e

Browse files
abrodkinacmel
authored andcommitted
perf tools: Fix statfs.f_type data type mismatch build error with uclibc
ARC Linux uses the no legacy syscalls abi and corresponding uClibc headers statfs defines f_type to be U32 which causes perf build breakage http://git.uclibc.org/uClibc/tree/libc/sysdeps/linux/common-generic/bits/statfs.h ----------->8--------------- CC fs/fs.o fs/fs.c: In function 'fs__valid_mount': fs/fs.c:82:24: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare] else if (st_fs.f_type != magic) ^ cc1: all warnings being treated as errors ----------->8--------------- Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Cc: Borislav Petkov <bp@suse.de> Cc: Cody P Schafer <dev@codyps.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com> Link: http://lkml.kernel.org/r/1420888254-17504-2-git-send-email-vgupta@synopsys.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 25cd480 commit db1806e

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

tools/lib/api/fs/debugfs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ int debugfs_valid_mountpoint(const char *debugfs)
6767

6868
if (statfs(debugfs, &st_fs) < 0)
6969
return -ENOENT;
70-
else if (st_fs.f_type != (long) DEBUGFS_MAGIC)
70+
else if ((long)st_fs.f_type != (long)DEBUGFS_MAGIC)
7171
return -ENOENT;
7272

7373
return 0;

tools/lib/api/fs/fs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ static int fs__valid_mount(const char *fs, long magic)
7979

8080
if (statfs(fs, &st_fs) < 0)
8181
return -ENOENT;
82-
else if (st_fs.f_type != magic)
82+
else if ((long)st_fs.f_type != magic)
8383
return -ENOENT;
8484

8585
return 0;

0 commit comments

Comments
 (0)