arch/alpha/boot/tools/objstrip.c: wrong variable tested after open()

RoelKluin · torvalds · commit 27258e448eb3 · 2009-09-22T07:17:43.000-07:00
The incorrect variable is tested. fd is used for another open()
and is already tested.

Signed-off-by: Roel Kluin &lt;roel.kluin@gmail.com&gt;
Cc: Ivan Kokshaysky &lt;ink@jurassic.park.msu.ru&gt;
Cc: Richard Henderson &lt;rth@twiddle.net&gt;
Signed-off-by: Andrew Morton &lt;akpm@linux-foundation.org&gt;
Signed-off-by: Linus Torvalds &lt;torvalds@linux-foundation.org&gt;
diff --git a/arch/alpha/boot/tools/objstrip.c b/arch/alpha/boot/tools/objstrip.c
@@ -93,7 +93,7 @@ main (int argc, char *argv[])
     ofd = 1;
     if (i < argc) {
 	ofd = open(argv[i++], O_WRONLY | O_CREAT | O_TRUNC, 0666);
-	if (fd == -1) {
+	if (ofd == -1) {
 	    perror("open");
 	    exit(1);
 	}

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ main (int argc, char *argv[])`
`93`	`93`	`ofd = 1;`
`94`	`94`	`if (i < argc) {`
`95`	`95`	`ofd = open(argv[i++], O_WRONLY \| O_CREAT \| O_TRUNC, 0666);`
`96`		`- if (fd == -1) {`
	`96`	`+ if (ofd == -1) {`
`97`	`97`	`perror("open");`
`98`	`98`	`exit(1);`
`99`	`99`	`}`