# Apply Alexey's Exception memory leak patch #

Barton Cline · Barton Cline · commit 534b145c5d78 · 2012-01-26T08:07:09.000Z
# Apply Alexey's PythonException AquireLock patch #
diff --git a/pythonnet/src/runtime/exceptions.cs b/pythonnet/src/runtime/exceptions.cs
@@ -473,6 +473,7 @@ public static void SetError(Exception e) {
             IntPtr etype = Runtime.PyObject_GetAttrString(op, "__class__");
             Runtime.PyErr_SetObject(etype, op);
             Runtime.Decref(etype);
+            Runtime.Decref(op);
         }
 
         /// <summary>
diff --git a/pythonnet/src/runtime/pythonexception.cs b/pythonnet/src/runtime/pythonexception.cs
@@ -27,11 +27,11 @@ public class PythonException : System.Exception {
 
     public PythonException() : base()
     {
+        IntPtr gs = PythonEngine.AcquireLock();
         Runtime.PyErr_Fetch(ref _pyType, ref _pyValue, ref _pyTB);
         Runtime.Incref(_pyType);
         Runtime.Incref(_pyValue);
         Runtime.Incref(_pyTB);
-        IntPtr gs = PythonEngine.AcquireLock();
         if ((_pyType != IntPtr.Zero) && (_pyValue != IntPtr.Zero))
         {
             string type = new PyObject(_pyType).GetAttr("__name__").ToString();

Original file line number	Diff line number	Diff line change
`@@ -473,6 +473,7 @@ public static void SetError(Exception e) {`
`473`	`473`	`IntPtr etype = Runtime.PyObject_GetAttrString(op, "__class__");`
`474`	`474`	`Runtime.PyErr_SetObject(etype, op);`
`475`	`475`	`Runtime.Decref(etype);`
	`476`	`+ Runtime.Decref(op);`
`476`	`477`	`}`
`477`	`478`
`478`	`479`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,11 @@ public class PythonException : System.Exception {`
`27`	`27`
`28`	`28`	`public PythonException() : base()`
`29`	`29`	`{`
	`30`	`+ IntPtr gs = PythonEngine.AcquireLock();`
`30`	`31`	`Runtime.PyErr_Fetch(ref _pyType, ref _pyValue, ref _pyTB);`
`31`	`32`	`Runtime.Incref(_pyType);`
`32`	`33`	`Runtime.Incref(_pyValue);`
`33`	`34`	`Runtime.Incref(_pyTB);`
`34`		`- IntPtr gs = PythonEngine.AcquireLock();`
`35`	`35`	`if ((_pyType != IntPtr.Zero) && (_pyValue != IntPtr.Zero))`
`36`	`36`	`{`
`37`	`37`	`string type = new PyObject(_pyType).GetAttr("__name__").ToString();`