Skip to content

Commit dad0d91

Browse files
urezkiherbertx
authored andcommitted
mm/slab: Add kvfree_atomic() helper
kvmalloc() now supports non-sleeping GFP flags, including the vmalloc fallback path. This means it may return vmalloc memory even for GFP_ATOMIC and GFP_NOWAIT allocations. Freeing such memory with kvfree() may then end up calling vfree(), which is not safe for non-sleeping contexts. Introduce kvfree_atomic() helper for such cases. It mirrors kvfree(), but uses vfree_atomic() for vmalloced memory. Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com> Acked-by: Vlastimil Babka (SUSE) <vbabka@kernel.org> Acked-by: Harry Yoo (Oracle) <harry@kernel.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
1 parent 09ae540 commit dad0d91

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

include/linux/slab.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,6 +1234,9 @@ void *kvrealloc_node_align_noprof(const void *p, size_t size, unsigned long alig
12341234
extern void kvfree(const void *addr);
12351235
DEFINE_FREE(kvfree, void *, if (!IS_ERR_OR_NULL(_T)) kvfree(_T))
12361236

1237+
extern void kvfree_atomic(const void *addr);
1238+
DEFINE_FREE(kvfree_atomic, void *, if (!IS_ERR_OR_NULL(_T)) kvfree_atomic(_T))
1239+
12371240
extern void kvfree_sensitive(const void *addr, size_t len);
12381241

12391242
unsigned int kmem_cache_size(struct kmem_cache *s);

mm/slub.c

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6882,6 +6882,22 @@ void kvfree(const void *addr)
68826882
}
68836883
EXPORT_SYMBOL(kvfree);
68846884

6885+
/**
6886+
* kvfree_atomic() - Free memory.
6887+
* @addr: Pointer to allocated memory.
6888+
*
6889+
* Same as kvfree(), but uses vfree_atomic() for vmalloc
6890+
* backed memory. Must not be called from NMI context.
6891+
*/
6892+
void kvfree_atomic(const void *addr)
6893+
{
6894+
if (is_vmalloc_addr(addr))
6895+
vfree_atomic(addr);
6896+
else
6897+
kfree(addr);
6898+
}
6899+
EXPORT_SYMBOL(kvfree_atomic);
6900+
68856901
/**
68866902
* kvfree_sensitive - Free a data object containing sensitive information.
68876903
* @addr: address of the data object to be freed.

0 commit comments

Comments
 (0)