Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: linuxmint/xapp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: linuxmint/xapp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2.2-maintenance
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 6 files changed
  • 1 contributor

Commits on Oct 20, 2022

  1. Add missing build dependency. 

    We need to use the gi module to reliably find the overrides
directory.
    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    542f663 View commit details
    Browse the repository at this point in the history

  2. Use github actions for CI builds.

    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    ea00e7f View commit details
    Browse the repository at this point in the history

  3. sn-item: Don't update the icon name if the tooltip was also updated. 

    The tooltip update also calls assign_sortable_name (appindicator apps
don't have real tooltips, we set it to their names).

In fallback mode, this ends up calling gtk_status_icon_set_name,
which re-embeds the GtkStatusIcon, causing a recursive loop.
    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    5dc2fc6 View commit details
    Browse the repository at this point in the history

  4. sn-item: Don't update the id property unless it has changed. 

    This can also cause extra updates (though not recursive), which
causes visual issues with apps that provide frequent graphic updates
to the icons (like indicator-multiload).
    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    1520996 View commit details
    Browse the repository at this point in the history

  5. xapp-status-icon.c: Update all icons when we lose or regain our 

    identity on dbus.

xapp-sn-watcher spawns multiple icons from a single process. It
only has a single name on the bus but exports multiple paths for
the icons. If the name is lost or gained, all icons should react.
    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    d5d7c37 View commit details
    Browse the repository at this point in the history

  6. sn-item: Silence warning caused when an app exits without notice. 

    Slack stops processing dbus traffic before it actually stops
advertising itself.
    @mtwebster
    mtwebster committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    074607e View commit details
    Browse the repository at this point in the history
Loading