Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: linuxmint/xapp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: linuxmint/xapp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.8-maintenance
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 4 files changed
  • 2 contributors

Commits on Sep 2, 2020

  1. sn-item.c: Prefer an icon name from the system theme instead of always

    sending an icon path. This doesn't work for symbolic icons.
    mtwebster committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    785e29a View commit details
    Browse the repository at this point in the history
  2. sn-item.c: Always set an available icon, regardless of visibility state

    requested by an app.  The icon and visibility state aren't necessarily set
    at the same time.
    
    Reproduced with kdeconnect.
    mtwebster committed Sep 2, 2020
    Configuration menu
    Copy the full SHA
    fe33361 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. 1.8.10

    clefebvre committed Sep 9, 2020
    Configuration menu
    Copy the full SHA
    a0fa7a5 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2020

  1. sn-item.c: Update the icon also, if the client's state changes.

    The state can decide which icon to use, so if it changes, the icon
    may also, even if we haven't gotten an explicit icon changed signal.
    mtwebster committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    f9490a2 View commit details
    Browse the repository at this point in the history
  2. xapp-sn-watcher.c: Don't try to use a null pointer as a hash table

    lookup key.
    
    When a new item tries to register, its key is added to the item table
    with a null value, to prevent trying to register the same client
    multiple times. When registration is finished, the key is removed,
    and re-used to add the new item to the table.
    
    If the app disappears before that registration finishes, we remove
    its key from the table (handle_sn_item_name_owner_lost), so when the
    item registration completes (it will because a proxy doesn't need an
    owner), our steal/re-add fails because the key was removed already.
    
    This will have us steal the key early when completing registration,
    and abort if it's null.
    
    Also wrap g_object_unref when removing an item from the table to
    prevent a warning.
    mtwebster committed Sep 30, 2020
    Configuration menu
    Copy the full SHA
    81defe8 View commit details
    Browse the repository at this point in the history
Loading