spot fix open-source-parsers#1171: isprint argument must be representable as unsigned char (open-source-parsers#1173)

BillyDonahue · web-flow · commit 75b360af4ae3 · 2020-05-13T18:37:02.000-04:00
diff --git a/src/lib_json/json_writer.cpp b/src/lib_json/json_writer.cpp
@@ -178,7 +178,7 @@ String valueToString(bool value) { return value ? "true" : "false"; }
 static bool isAnyCharRequiredQuoting(char const* s, size_t n) {
   assert(s || !n);
 
-  return std::any_of(s, s + n, [](int c) {
+  return std::any_of(s, s + n, [](unsigned char c) {
     return c == '\\' || c == '"' || !std::isprint(c);
   });
 }

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ String valueToString(bool value) { return value ? "true" : "false"; }`
`178`	`178`	`static bool isAnyCharRequiredQuoting(char const* s, size_t n) {`
`179`	`179`	`assert(s \|\| !n);`
`180`	`180`
`181`		`- return std::any_of(s, s + n, [](int c) {`
	`181`	`+ return std::any_of(s, s + n, [](unsigned char c) {`
`182`	`182`	`return c == '\\' \|\| c == '"' \|\| !std::isprint(c);`
`183`	`183`	`});`
`184`	`184`	`}`