Updating custom scalar tests based on agreed discussion that custom scalars should show regardless of being used or not

simeonleatherland · simeonleatherland · commit cb87286bacd7 · 2020-02-05T16:32:36.000+11:00
diff --git a/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy b/src/test/groovy/graphql/schema/idl/SchemaPrinterTest.groovy
@@ -1440,7 +1440,7 @@ scalar RandomScalar
 '''
         }
 
-    def "omit unused custom scalars when unused - created by sdl string"(){
+    def "show unused custom scalars when unused - created by sdl string"(){
         given:
         def sdl = '''type Query {astring : String aInt : Int} "Some Scalar" scalar CustomScalar'''
 
@@ -1459,6 +1459,9 @@ scalar RandomScalar
   aInt: Int
   astring: String
 }
+
+"CustomScalar"
+scalar CustomScalar
 '''
     }
 
@@ -1502,7 +1505,7 @@ scalar RandomScalar
 '''
     }
 
-    def "omit unused custom scalars when unused - created programmatically"(){
+    def "show unused custom scalars when unused - created programmatically"(){
         given:
         GraphQLScalarType myScalar = new GraphQLScalarType("Scalar", "about scalar", new Coercing() {
             @Override
@@ -1534,6 +1537,8 @@ scalar RandomScalar
   someType: Int
 }
 
+"about scalar"
+scalar Scalar
 '''
     }
 

Original file line number	Diff line number	Diff line change
`@@ -1440,7 +1440,7 @@ scalar RandomScalar`
`1440`	`1440`	`'''`
`1441`	`1441`	`}`
`1442`	`1442`
`1443`		`- def "omit unused custom scalars when unused - created by sdl string"(){`
	`1443`	`+ def "show unused custom scalars when unused - created by sdl string"(){`
`1444`	`1444`	`given:`
`1445`	`1445`	`def sdl = '''type Query {astring : String aInt : Int} "Some Scalar" scalar CustomScalar'''`
`1446`	`1446`
`@@ -1459,6 +1459,9 @@ scalar RandomScalar`
`1459`	`1459`	`aInt: Int`
`1460`	`1460`	`astring: String`
`1461`	`1461`	`}`
	`1462`	`+`
	`1463`	`+"CustomScalar"`
	`1464`	`+scalar CustomScalar`
`1462`	`1465`	`'''`
`1463`	`1466`	`}`
`1464`	`1467`
`@@ -1502,7 +1505,7 @@ scalar RandomScalar`
`1502`	`1505`	`'''`
`1503`	`1506`	`}`
`1504`	`1507`
`1505`		`- def "omit unused custom scalars when unused - created programmatically"(){`
	`1508`	`+ def "show unused custom scalars when unused - created programmatically"(){`
`1506`	`1509`	`given:`
`1507`	`1510`	`GraphQLScalarType myScalar = new GraphQLScalarType("Scalar", "about scalar", new Coercing() {`
`1508`	`1511`	`@Override`
`@@ -1534,6 +1537,8 @@ scalar RandomScalar`
`1534`	`1537`	`someType: Int`
`1535`	`1538`	`}`
`1536`	`1539`
	`1540`	`+"about scalar"`
	`1541`	`+scalar Scalar`
`1537`	`1542`	`'''`
`1538`	`1543`	`}`
`1539`	`1544`