Bug fix: Service Discovery Service Name is correctly set from ECS Params

PettitWesley · PettitWesley · commit b55a2f2b3bc5 · 2018-10-17T21:48:17.000-07:00
diff --git a/ecs-cli/modules/cli/servicediscovery/servicediscovery_app_test.go b/ecs-cli/modules/cli/servicediscovery/servicediscovery_app_test.go
@@ -37,7 +37,7 @@ import (
 const (
 	testClusterName        = "cluster"
 	testServiceName        = "service"
-	otherTestServiceName   = "some-other-name"
+	nonDefaultSDSName      = "some-custom-name"
 	testDescription        = "clyde loves pudding"
 	otherTestDescription   = "pudding plays hard to get"
 	testNamespaceStackName = "amazon-ecs-cli-setup-private-dns-namespace-cluster-service"
@@ -232,7 +232,7 @@ func TestCreateServiceDiscoveryWithECSParams(t *testing.T) {
 			Description: testDescription,
 		},
 		ServiceDiscoveryService: utils.ServiceDiscoveryService{
-			Name:        otherTestServiceName,
+			Name:        nonDefaultSDSName,
 			Description: testDescription,
 			DNSConfig: utils.DNSConfig{
 				TTL:  aws.Int64(60),
@@ -251,7 +251,7 @@ func TestCreateServiceDiscoveryWithECSParams(t *testing.T) {
 	}
 	var validateSDS validateSDSParamsFunc = func(t *testing.T, cfnParams *cloudformation.CfnStackParams) {
 		validateCFNParam(testNamespaceID, parameterKeyNamespaceID, cfnParams, t)
-		validateCFNParam(otherTestServiceName, parameterKeySDSName, cfnParams, t)
+		validateCFNParam(nonDefaultSDSName, parameterKeySDSName, cfnParams, t)
 		validateCFNParam(servicediscovery.RecordTypeSrv, parameterKeyDNSType, cfnParams, t)
 		validateCFNParam(testDescription, parameterKeySDSDescription, cfnParams, t)
 		validateCFNParam("60", parameterKeyDNSTTL, cfnParams, t)
