added int's as parameters

joeferner · joeferner · commit 463345caf3be · 2012-01-20T12:07:06.000-05:00
diff --git a/src/java.cpp b/src/java.cpp
@@ -125,7 +125,13 @@ v8::Handle<v8::Value> Java::createJVM(JavaVM** jvm, JNIEnv** env) {
   if(clazz == NULL) {
     std::ostringstream errStr;
     errStr << "Could not create class " << className.c_str();
-    return javaExceptionToV8(env, errStr.str());
+    v8::Handle<v8::Value> error = javaExceptionToV8(env, errStr.str());
+
+    v8::Handle<v8::Value> argv[2];
+    argv[0] = error;
+    argv[1] = v8::Undefined();
+    v8::Function::Cast(*callback)->Call(v8::Context::GetCurrent()->Global(), 2, argv);
+    return v8::Undefined();
   }
   std::list<jobject> constructors = javaReflectionGetConstructors(env, clazz);
   jobject method = javaFindBestMatchingConstructor(env, constructors, methodArgTypes);
@@ -163,7 +169,7 @@ v8::Handle<v8::Value> Java::createJVM(JavaVM** jvm, JNIEnv** env) {
   if(clazz == NULL) {
     std::ostringstream errStr;
     errStr << "Could not create class " << className.c_str();
-    return javaExceptionToV8(env, errStr.str());
+    return ThrowException(javaExceptionToV8(env, errStr.str()));
   }
   std::list<jobject> constructors = javaReflectionGetConstructors(env, clazz);
   jobject method = javaFindBestMatchingConstructor(env, constructors, methodArgTypes);
diff --git a/src/utils.cpp b/src/utils.cpp
@@ -150,6 +150,12 @@ jobject v8ToJava(JNIEnv* env, v8::Local<v8::Value> arg, int *methodArgType) {
     *methodArgType = TYPE_STRING;
     v8::String::AsciiValue val(arg->ToString());
     return env->NewStringUTF(*val);
+  } else if(arg->IsInt32()) {
+    jint val = arg->ToInt32()->Value();
+    *methodArgType = TYPE_INT;
+    jclass clazz = env->FindClass("java/lang/Integer");
+    jmethodID constructor = env->GetMethodID(clazz, "<init>", "(I)V");
+    return env->NewObject(clazz, constructor, val);
   } else {
     // TODO: handle other arg types
     *methodArgType = TYPE_OBJECT;
diff --git a/test/simple-test.js b/test/simple-test.js
@@ -67,7 +67,9 @@ exports['Simple'] = nodeunit.testCase({
     list.addSync("hello");
     list.addSync("world");
     test.equal(list.sizeSync(), 2);
-    list.clearSync();
+    console.log("before get");
+    var item0 = list.getSync(0);
+    test.equal(item0.toStringSync(), "hello");
     var clazz = list.getClassSync();
     var result = clazz.getNameSync();
     test.equal(result, "java.util.ArrayList");
