if you exceed CHUNK_SIZE safari will crash with a range error

chrisnojima · chrisnojima · commit 37ff49576294 · 2019-10-29T10:57:06.000-04:00
diff --git a/src/utils/utf8.ts b/src/utils/utf8.ts
@@ -138,7 +138,7 @@ export function utf8DecodeJs(bytes: Uint8Array, inputOffset: number, byteLength:
       units.push(byte1);
     }
 
-    if (units.length - 4 >= CHUNK_SIZE) {
+    if (units.length >= CHUNK_SIZE) {
       result += String.fromCharCode(...units);
       units.length = 0;
     }

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ export function utf8DecodeJs(bytes: Uint8Array, inputOffset: number, byteLength:`
`138`	`138`	`units.push(byte1);`
`139`	`139`	`}`
`140`	`140`
`141`		`- if (units.length - 4 >= CHUNK_SIZE) {`
	`141`	`+ if (units.length >= CHUNK_SIZE) {`
`142`	`142`	`result += String.fromCharCode(...units);`
`143`	`143`	`units.length = 0;`
`144`	`144`	`}`