Add callback parameter to weakref, at the moment this callback isn't yet

skinnyBat · skinnyBat · commit c01dc5310a45 · 2019-04-04T20:11:53.000+13:00
implement though.
diff --git a/tests/snippets/test_abc.py b/tests/snippets/test_abc.py
@@ -13,6 +13,7 @@ def __subclasshook__(cls, subclass):
         return NotImplemented
 
 
+# TODO raise an error if there are in any abstract methods not fulfilled
 # with assertRaises(TypeError):
 #     CustomInterface()
 
@@ -31,4 +32,8 @@ class SubConcrete(Concrete):
 
 assert issubclass(Concrete, CustomInterface)
 assert issubclass(SubConcrete, CustomInterface)
+assert not issubclass(tuple, CustomInterface)
 
+assert isinstance(Concrete(), CustomInterface)
+assert isinstance(SubConcrete(), CustomInterface)
+assert not isinstance((), CustomInterface)
diff --git a/vm/src/obj/objweakref.rs b/vm/src/obj/objweakref.rs
@@ -3,6 +3,7 @@ use crate::pyobject::PyValue;
 use crate::pyobject::{PyContext, PyObject, PyObjectPayload, PyObjectRef, PyRef, PyResult};
 use crate::vm::VirtualMachine;
 
+use crate::function::OptionalArg;
 use std::rc::{Rc, Weak};
 
 #[derive(Debug)]
@@ -32,7 +33,12 @@ pub type PyWeakRef = PyRef<PyWeak>;
 
 impl PyWeakRef {
     // TODO callbacks
-    fn create(cls: PyClassRef, referent: PyObjectRef, vm: &VirtualMachine) -> PyResult<Self> {
+    fn create(
+        cls: PyClassRef,
+        referent: PyObjectRef,
+        _callback: OptionalArg<PyObjectRef>,
+        vm: &VirtualMachine,
+    ) -> PyResult<Self> {
         PyWeak::downgrade(&referent).into_ref_with_type(vm, cls)
     }
 
