added exception when calling Git2\Commit::create

chobie · chobie · commit c9d9fb408e99 · 2012-01-29T19:29:43.000+09:00
diff --git a/commit.c b/commit.c
@@ -223,6 +223,9 @@ PHP_METHOD(git2_commit, create)
 	if (zend_hash_find(hash,"author",sizeof("author"),(void **)&value_pp) != FAILURE) {
 		z_author = *value_pp;
 		m_author = PHP_GIT2_GET_OBJECT(php_git2_signature,z_author);
+	} else {
+		zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'author' required");
+		return;
 	}
 
 	if (zend_hash_find(hash,"committer",sizeof("committer"),(void **)&value_pp) != FAILURE) {
@@ -243,6 +246,9 @@ PHP_METHOD(git2_commit, create)
 			m_tree = PHP_GIT2_GET_OBJECT(php_git2_tree, z_tree);
 			tree = m_tree->tree;
 		}
+	} else {
+		zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'tree' required");
+		return;
 	}
 
 	if (zend_hash_find(hash,"parents",sizeof("parents"),(void **)&value_pp) != FAILURE) {
@@ -259,6 +265,9 @@ PHP_METHOD(git2_commit, create)
 
 	if (zend_hash_find(hash,"message",sizeof("message"),(void **)&value_pp) != FAILURE) {
 		message = Z_STRVAL_PP(value_pp);
+	} else {
+		zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'message' required");
+		return;
 	}
 
 	if (zend_hash_find(hash,"encoding",sizeof("encoding"),(void **)&value_pp) != FAILURE) {

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,9 @@ PHP_METHOD(git2_commit, create)`
`223`	`223`	`if (zend_hash_find(hash,"author",sizeof("author"),(void **)&value_pp) != FAILURE) {`
`224`	`224`	`z_author = *value_pp;`
`225`	`225`	`m_author = PHP_GIT2_GET_OBJECT(php_git2_signature,z_author);`
	`226`	`+ } else {`
	`227`	`+ zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'author' required");`
	`228`	`+ return;`
`226`	`229`	`}`
`227`	`230`
`228`	`231`	`if (zend_hash_find(hash,"committer",sizeof("committer"),(void **)&value_pp) != FAILURE) {`
`@@ -243,6 +246,9 @@ PHP_METHOD(git2_commit, create)`
`243`	`246`	`m_tree = PHP_GIT2_GET_OBJECT(php_git2_tree, z_tree);`
`244`	`247`	`tree = m_tree->tree;`
`245`	`248`	`}`
	`249`	`+ } else {`
	`250`	`+ zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'tree' required");`
	`251`	`+ return;`
`246`	`252`	`}`
`247`	`253`
`248`	`254`	`if (zend_hash_find(hash,"parents",sizeof("parents"),(void **)&value_pp) != FAILURE) {`
`@@ -259,6 +265,9 @@ PHP_METHOD(git2_commit, create)`
`259`	`265`
`260`	`266`	`if (zend_hash_find(hash,"message",sizeof("message"),(void **)&value_pp) != FAILURE) {`
`261`	`267`	`message = Z_STRVAL_PP(value_pp);`
	`268`	`+ } else {`
	`269`	`+ zend_throw_exception_ex(spl_ce_InvalidArgumentException, 0 TSRMLS_CC,"key 'message' required");`
	`270`	`+ return;`
`262`	`271`	`}`
`263`	`272`
`264`	`273`	`if (zend_hash_find(hash,"encoding",sizeof("encoding"),(void **)&value_pp) != FAILURE) {`