[index] implment several functions

chobie · chobie · commit 7e31ddb0d9b9 · 2014-01-11T16:16:56.000+09:00
diff --git a/commit.c b/commit.c
@@ -469,17 +469,6 @@ PHP_FUNCTION(git_commit_nth_gen_ancestor)
 
 }
 
-static zval* php_git2_read_arrval(zval *array, char *name, size_t name_len TSRMLS_DC)
-{
-	zval *result = NULL, **element;
-
-	if (zend_hash_find(Z_ARRVAL_P(array), name, name_len, (void**)&element) == SUCCESS) {
-		result = *element;
-	}
-
-	return result;
-}
-
 static void php_git2_array_to_signature(git_signature *signature, zval *author TSRMLS_DC)
 {
 	zval *name = NULL, *email = NULL, *time = NULL;
diff --git a/helper.c b/helper.c
@@ -16,3 +16,41 @@ int php_git2_check_error(int error_code, const char *action TSRMLS_DC)
 	result = 1;
 	return result;
 }
+
+
+zval* php_git2_read_arrval(zval *array, char *name, size_t name_len TSRMLS_DC)
+{
+	zval *result = NULL, **element;
+
+	if (zend_hash_find(Z_ARRVAL_P(array), name, name_len, (void**)&element) == SUCCESS) {
+		result = *element;
+	}
+
+	return result;
+}
+
+long php_git2_read_arrval_long(zval *array, char *name, size_t name_len TSRMLS_DC)
+{
+	zval *tmp;
+	long result = 0;
+
+	tmp = php_git2_read_arrval(array, name, name_len TSRMLS_CC);
+	if (tmp) {
+		result = Z_LVAL_P(tmp);
+	}
+
+	return result;
+}
+
+const char* php_git2_read_arrval_string(zval *array, char *name, size_t name_len TSRMLS_DC)
+{
+	zval *tmp;
+	const char *result = NULL;
+
+	tmp = php_git2_read_arrval(array, name, name_len TSRMLS_CC);
+	if (tmp) {
+		result = Z_STRVAL_P(tmp);
+	}
+
+	return result;
+}
diff --git a/helper.h b/helper.h
@@ -30,4 +30,10 @@
 
 int php_git2_check_error(int error_code, const char *action TSRMLS_DC);
 
+zval* php_git2_read_arrval(zval *array, char *name, size_t name_len TSRMLS_DC);
+
+long php_git2_read_arrval_long(zval *array, char *name, size_t name_len TSRMLS_DC);
+
+const char* php_git2_read_arrval_string(zval *array, char *name, size_t name_len TSRMLS_DC);
+
 #endif
diff --git a/index.c b/index.c
