Extend safe.directory admin-owner check to also cover non-elevated processes#7273
Open
csware wants to merge 1 commit into
Open
Extend safe.directory admin-owner check to also cover non-elevated processes#7273csware wants to merge 1 commit into
csware wants to merge 1 commit into
Conversation
Contributor
Author
|
I found no documentation whether or how the handle needs to be freed. |
…ted processes The current implementation which checks whether the current user is in the administrators group only works if the process runs elevated. Another check using a so-called "linked token" is necessary which exists when administrators run in non-elevated mode. Based on Git commit 03a4e46d122d5f24b6e1cd872eb996851c1563da. Signed-off-by: Sven Strickroth <email@cs-ware.de>
e74dbc4 to
38ce4c8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation which checks whether the current user is in the administrators group only works if the process runs elevated.
Another check using a so-called "linked token" is necessary which exists when administrators run in non-elevated mode.
Based on Git commit 03a4e46d122d5f24b6e1cd872eb996851c1563da.