CLI: commit command#7259
Open
ethomson wants to merge 8 commits into
Open
Conversation
Introduce `git_commit_create_ext` and an options structure for extensibility. Non-default arguments (message encoding, reference updates) are in the options structure. This simplifies the complex self-service commit creation APIs and allows for future sustainable improvements.
Some clients (eg GitButler) are storing additional information in custom user-specified commit headers. We should make this a first-class concept.
Callers can now introduce a commit signing callback instead of needing to call a specialized commit buffer creation function.
`GIT_ASSERT` is not necessarily useful for the CLI; we need something that prints to stderr and exits.
The process options structure should be allowed to be `NULL`; treated as if it's empty.
Similar to the `git_commit_create_from_stage` function, a batteries- included commit creation function that uses smart defaults and commits a given tree.
Similar to the `git_commit_create_from_...` APIs, a simple amend function that uses smart defaults and amends HEAD from the staged changes or a given tree.
904fa9c to
a8f9efb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a
git commit-style command.