Add build flag for disable http transport#7245
Open
mrdimidium wants to merge 1 commit into
Open
Conversation
Member
|
Yeah, this makes sense. I'd like to think through some of our options a little bit - do we really need Anyway, thanks for the fix and we'll make sure that you can slim down your build 🔜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your library; it's really convenient.
This PR proposes a new build flag that allows you to completely exclude HTTP from the build and get libgit2 without networking.
My application works with already cloned bare repositories, reads only, and doesn't require networking. Although libgit2 includes an HTTP parser, it's a large external C library. I'd like to avoid both the extra size (it's about 25KB in a stripped .so) and the attack surface.
This flag is enabled by default and doesn't change the current behavior. For consistency, I added a field to the feature struct. This affects the public API, but I expect it won't break backwards compatibility with either the API or the ABI.