repository: fix leaking buffer in git_repository_head_for_worktree

pks-t · pks-t · commit ff07b9bfc9ae · 2017-05-02T14:21:07.000+02:00
The cleanup procedure calls `git_buf_clear` on the buffer, which simply
causes it to be truncated instead of being freed. Fix the issue by
calling `git_buf_free` instead.
diff --git a/src/repository.c b/src/repository.c
@@ -2132,7 +2132,7 @@ int git_repository_head_for_worktree(git_reference **out, git_repository *repo,
 out:
 	if (error)
 		git_reference_free(head);
-	git_buf_clear(&path);
+	git_buf_free(&path);
 
 	return error;
 }

Original file line number	Diff line number	Diff line change
`@@ -2132,7 +2132,7 @@ int git_repository_head_for_worktree(git_reference *out, git_repository repo,`
`2132`	`2132`	`out:`
`2133`	`2133`	`if (error)`
`2134`	`2134`	`git_reference_free(head);`
`2135`		`- git_buf_clear(&path);`
	`2135`	`+ git_buf_free(&path);`
`2136`	`2136`
`2137`	`2137`	`return error;`
`2138`	`2138`	`}`