Update eviction queue before size

rstoyanchev · rstoyanchev · commit b451379c2f6d · 2020-07-16T17:28:32.000+03:00
See spring-projectsgh-25298
diff --git a/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java b/spring-messaging/src/main/java/org/springframework/messaging/simp/broker/DefaultSubscriptionRegistry.java
@@ -263,8 +263,9 @@ public LinkedMultiValueMap<String, String> getSubscriptions(String destination)
 			if (sessionIdToSubscriptionIds == null) {
 				sessionIdToSubscriptionIds = this.destinationCache.computeIfAbsent(destination, _destination -> {
 					LinkedMultiValueMap<String, String> matches = computeMatchingSubscriptions(destination);
-					this.cacheSize.incrementAndGet();
+					// Update queue first, so that cacheSize <= queue.size(
 					this.cacheEvictionPolicy.add(destination);
+					this.cacheSize.incrementAndGet();
 					return matches;
 				});
 				ensureCacheLimit();
@@ -309,7 +310,9 @@ private void ensureCacheLimit() {
 			if (size > cacheLimit) {
 				do {
 					if (this.cacheSize.compareAndSet(size, size - 1)) {
-						this.destinationCache.remove(this.cacheEvictionPolicy.poll());
+						// Remove (vs poll): we expect an element
+						String head = this.cacheEvictionPolicy.remove();
+						this.destinationCache.remove(head);
 					}
 				} while ((size = this.cacheSize.get()) > cacheLimit);
 			}
