Follow references in responses.

tilaks · tilaks · commit 84d3109b6c8c · 2023-10-21T18:58:39.000-04:00
diff --git a/openapi_python_client/parser/openapi.py b/openapi_python_client/parser/openapi.py
@@ -568,7 +568,12 @@ def from_dict(data: Dict[str, Any], *, config: Config) -> Union["GeneratorData",
         schemas = Schemas()
         parameters = Parameters()
         if openapi.components and openapi.components.schemas:
-            schemas = build_schemas(components=openapi.components.schemas, schemas=schemas, config=config)
+            schemas = build_schemas(
+                input_schemas=openapi.components.schemas,
+                input_responses=openapi.components.responses,
+                schemas=schemas,
+                config=config,
+            )
         if openapi.components and openapi.components.parameters:
             parameters = build_parameters(
                 components=openapi.components.parameters, parameters=parameters, config=config
diff --git a/openapi_python_client/parser/properties/__init__.py b/openapi_python_client/parser/properties/__init__.py
@@ -811,9 +811,12 @@ def property_from_data(
 
 
 def _create_schemas(
-    *, components: Dict[str, Union[oai.Reference, oai.Schema]], schemas: Schemas, config: Config
+    *,
+    input_schemas: Dict[str, Union[oai.Reference, oai.Schema]],
+    schemas: Schemas,
+    config: Config,
 ) -> Schemas:
-    to_process: Iterable[Tuple[str, Union[oai.Reference, oai.Schema]]] = components.items()
+    to_process: Iterable[Tuple[str, Union[oai.Reference, oai.Schema]]] = input_schemas.items()
     still_making_progress = True
     errors: List[PropertyError] = []
 
@@ -844,6 +847,32 @@ def _create_schemas(
     return schemas
 
 
+def _process_responses(
+    *,
+    input_responses: Dict[str, oai.Response],
+    schemas: Schemas,
+    config: Config,
+) -> Schemas:
+    for name, data in input_responses.items():
+        if not isinstance(data, oai.Response):
+            schemas.errors.append(PropertyError(data=data, detail="Only reference schemas are supported."))
+            continue
+
+        schema_ref_path = parse_reference_path(f"#/components/schemas/{name}")
+        if isinstance(schema_ref_path, ParseError):
+            schemas.errors.append(PropertyError(detail=schema_ref_path.detail, data=data))
+            continue
+        response_ref_path = parse_reference_path(f"#/components/responses/{name}")
+        if isinstance(response_ref_path, ParseError):
+            schemas.errors.append(PropertyError(detail=response_ref_path.detail, data=data))
+            continue
+
+        prop = schemas.classes_by_reference.get(schema_ref_path)
+        if prop:
+            schemas = evolve(schemas, classes_by_reference={response_ref_path: prop, **schemas.classes_by_reference})
+    return schemas
+
+
 def _propogate_removal(*, root: Union[ReferencePath, utils.ClassName], schemas: Schemas, error: PropertyError) -> None:
     if isinstance(root, utils.ClassName):
         schemas.classes_by_name.pop(root, None)
@@ -904,10 +933,16 @@ def _process_models(*, schemas: Schemas, config: Config) -> Schemas:
 
 
 def build_schemas(
-    *, components: Dict[str, Union[oai.Reference, oai.Schema]], schemas: Schemas, config: Config
+    *,
+    input_schemas: Dict[str, Union[oai.Reference, oai.Schema]],
+    input_responses: Optional[Dict[str, Union[oai.Reference, oai.Schema]]],
+    schemas: Schemas,
+    config: Config,
 ) -> Schemas:
     """Get a list of Schemas from an OpenAPI dict"""
-    schemas = _create_schemas(components=components, schemas=schemas, config=config)
+    schemas = _create_schemas(input_schemas=input_schemas, schemas=schemas, config=config)
+    if input_responses:
+        schemas = _process_responses(input_responses=input_responses, schemas=schemas, config=config)
     schemas = _process_models(schemas=schemas, config=config)
     return schemas
 
diff --git a/openapi_python_client/parser/responses.py b/openapi_python_client/parser/responses.py
@@ -69,11 +69,20 @@ def response_from_data(
 
     response_name = f"response_{status_code}"
     if isinstance(data, oai.Reference):
-        return (
-            empty_response(status_code=status_code, response_name=response_name, config=config, description=None),
-            schemas,
+        prop, schemas = property_from_data(
+            name=response_name,
+            required=True,
+            data=data,
+            schemas=schemas,
+            parent_name=parent_name,
+            config=config,
         )
 
+        if isinstance(prop, PropertyError):
+            return prop, schemas
+
+        return Response(status_code=status_code, prop=prop, source=None), schemas
+
     content = data.content
     if not content:
         return (
