Do not reject Windows' reserved device names on non-Windows platforms. (PowerShell#3252)

jeffbi · daxian-dbw · commit 97be759cc7bd · 2017-03-07T10:29:20.000-08:00
diff --git a/src/System.Management.Automation/engine/Utils.cs b/src/System.Management.Automation/engine/Utils.cs
@@ -1110,6 +1110,7 @@ internal static void NativeEnumerateDirectory(string directory, out List<string>
 
         internal static bool IsReservedDeviceName(string destinationPath)
         {
+#if !UNIX
             string[] reservedDeviceNames = { "CON", "PRN", "AUX", "CLOCK$", "NUL",
                                              "COM0", "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
                                              "LPT0", "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9" };
@@ -1133,7 +1134,7 @@ internal static bool IsReservedDeviceName(string destinationPath)
                     return true;
                 }
             }
-
+#endif
             return false;
         }
 
diff --git a/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1 b/test/powershell/Modules/Microsoft.PowerShell.Management/FileSystem.Tests.ps1
@@ -1,3 +1,4 @@
+Import-Module $PSScriptRoot\..\..\Common\Test.Helpers.psm1
 Describe "Basic FileSystem Provider Tests" -Tags "CI" {
     BeforeAll {
         $testDir = "TestDir"
@@ -20,6 +21,9 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
             $newTestFile = "NewTestFile.txt"
             $testContent = "Some Content"
             $testContent2 = "More Content"
+            $reservedNames = "CON", "PRN", "AUX", "CLOCK$", "NUL",
+                             "COM0", "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",
+                             "LPT0", "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9"
         }
 
         BeforeEach {
@@ -103,6 +107,53 @@ Describe "Basic FileSystem Provider Tests" -Tags "CI" {
             $contentBefore.Count | Should Be 1
             $contentAfter.Count | Should Be 0
         }
+
+         It "Copy-Item on Windows rejects Windows reserved device names" -Skip:(-not $IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                { Copy-Item -Path $testFile -Destination $deviceName -ErrorAction Stop } | ShouldBeErrorId "CopyError,Microsoft.PowerShell.Commands.CopyItemCommand"
+             }
+         }
+
+         It "Move-Item on Windows rejects Windows reserved device names" -Skip:(-not $IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                { Move-Item -Path $testFile -Destination $deviceName -ErrorAction Stop } | ShouldBeErrorId "MoveError,Microsoft.PowerShell.Commands.MoveItemCommand"
+             }
+         }
+
+         It "Rename-Item on Windows rejects Windows reserved device names" -Skip:(-not $IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                { Rename-Item -Path $testFile -NewName $deviceName -ErrorAction Stop } | ShouldBeErrorId "RenameError,Microsoft.PowerShell.Commands.RenameItemCommand"
+             }
+         }
+
+         It "Copy-Item on Unix succeeds with Windows reserved device names" -Skip:($IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                Copy-Item -Path $testFile -Destination $deviceName -Force -ErrorAction SilentlyContinue
+                Test-Path $deviceName | Should Be $true
+             }
+         }
+
+         It "Move-Item on Unix succeeds with Windows reserved device names" -Skip:($IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                Move-Item -Path $testFile -Destination $deviceName -Force -ErrorAction SilentlyContinue
+                Test-Path $deviceName | Should Be $true
+                New-Item -Path $testFile -ItemType File -Force -ErrorAction SilentlyContinue
+             }
+         }
+
+         It "Rename-Item on Unix succeeds with Windows reserved device names" -Skip:($IsWindows) {
+             foreach ($deviceName in $reservedNames)
+             {
+                Rename-Item -Path $testFile -NewName $deviceName -Force -ErrorAction SilentlyContinue
+                Test-Path $deviceName | Should Be $true
+                New-Item -Path $testFile -ItemType File -Force -ErrorAction SilentlyContinue
+             }
+         }
     }
 
     Context "Validate basic host navigation functionality" {
@@ -667,4 +718,4 @@ Describe "Extended FileSystem Path/Location Cmdlet Provider Tests" -Tags "Featur
             catch { $_.FullyQualifiedErrorId | Should Be "Argument,Microsoft.PowerShell.Commands.PopLocationCommand" }
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -1110,6 +1110,7 @@ internal static void NativeEnumerateDirectory(string directory, out List<string>`
`1110`	`1110`
`1111`	`1111`	`internal static bool IsReservedDeviceName(string destinationPath)`
`1112`	`1112`	`{`
	`1113`	`+#if !UNIX`
`1113`	`1114`	`string[] reservedDeviceNames = { "CON", "PRN", "AUX", "CLOCK$", "NUL",`
`1114`	`1115`	`"COM0", "COM1", "COM2", "COM3", "COM4", "COM5", "COM6", "COM7", "COM8", "COM9",`
`1115`	`1116`	`"LPT0", "LPT1", "LPT2", "LPT3", "LPT4", "LPT5", "LPT6", "LPT7", "LPT8", "LPT9" };`
`@@ -1133,7 +1134,7 @@ internal static bool IsReservedDeviceName(string destinationPath)`
`1133`	`1134`	`return true;`
`1134`	`1135`	`}`
`1135`	`1136`	`}`
`1136`		`-`
	`1137`	`+#endif`
`1137`	`1138`	`return false;`
`1138`	`1139`	`}`
`1139`	`1140`