GUI: Improve updating details view.

kimmov · kimmov · commit 0da55d64777a · 2010-11-23T22:37:31.000+02:00
After previous patches the details view was only updated when the
item was clicked with mouse. This patch improves the updating and
now it works also when changing selected item using keyboard.
diff --git a/gui/resultstree.cpp b/gui/resultstree.cpp
@@ -36,6 +36,7 @@
 #include <QFileDialog>
 #include <QClipboard>
 #include <QContextMenuEvent>
+#include <QModelIndex>
 #include "erroritem.h"
 #include "settings.h"
 #include "applicationlist.h"
@@ -939,3 +940,8 @@ void ResultsTree::Translate()
     //TODO go through all the errors in the tree and translate severity and message
 }
 
+void ResultsTree::currentChanged(const QModelIndex &current, const QModelIndex &previous)
+{
+    QTreeView::currentChanged(current, previous);
+    emit SelectionChanged(current);
+}
diff --git a/gui/resultstree.h b/gui/resultstree.h
@@ -32,6 +32,8 @@
 class Report;
 class ErrorItem;
 class ErrorLine;
+class QModelIndex;
+class QWidget;
 
 /// @addtogroup GUI
 /// @{
@@ -122,6 +124,16 @@ class ResultsTree : public QTreeView
     *
     */
     void Translate();
+
+signals:
+
+    /**
+    * @brief Signal for selection change in result tree.
+    *
+    * @param index Model index to specify new selected item.
+    */
+    void SelectionChanged(const QModelIndex &current);
+
 protected slots:
     /**
     * @brief Slot to quickstart an error with default application
@@ -161,6 +173,14 @@ protected slots:
     */
     void HideResult();
 
+    /**
+    * @brief Slot for selection change in the results tree.
+    *
+    * @param index Model index to specify new selected item.
+    * @param index Model index to specify previous selected item.
+    */
+    virtual void currentChanged(const QModelIndex &current, const QModelIndex &previous);
+
 protected:
 
     /**
diff --git a/gui/resultsview.cpp b/gui/resultsview.cpp
@@ -39,7 +39,7 @@ ResultsView::ResultsView(QWidget * parent) :
     mShowNoErrorsMessage(true)
 {
     mUI.setupUi(this);
-    connect(mUI.mTree, SIGNAL(clicked(const QModelIndex &)), this, SLOT(ItemClicked(const QModelIndex &)));
+    connect(mUI.mTree, SIGNAL(SelectionChanged(const QModelIndex &)), this, SLOT(UpdateDetails(const QModelIndex &)));
 }
 
 void ResultsView::Initialize(QSettings *settings, ApplicationList *list)
@@ -54,13 +54,11 @@ void ResultsView::Initialize(QSettings *settings, ApplicationList *list)
     mUI.mTree->Initialize(settings, list);
 }
 
-
 ResultsView::~ResultsView()
 {
     //dtor
 }
 
-
 void ResultsView::Clear()
 {
     mUI.mTree->Clear();
@@ -266,7 +264,7 @@ void ResultsView::ReadErrorsXml(const QString &filename)
     mUI.mTree->SetCheckDirectory("");
 }
 
-void ResultsView::ItemClicked(const QModelIndex &index)
+void ResultsView::UpdateDetails(const QModelIndex &index)
 {
     QStandardItemModel *model = qobject_cast<QStandardItemModel*>(mUI.mTree->model());
     QStandardItem *item = model->itemFromIndex(index);
diff --git a/gui/resultsview.h b/gui/resultsview.h
@@ -182,11 +182,11 @@ public slots:
     void ShowHiddenResults();
 
     /**
-    * @brief Update detailed message when item is clicked.
+    * @brief Update detailed message when selected item is changed.
     *
-    * @param index Position of item clicked.
+    * @param index Position of new selected item.
     */
-    void ItemClicked(const QModelIndex &index);
+    void UpdateDetails(const QModelIndex &index);
 
 protected:
     /**

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ ResultsView::ResultsView(QWidget * parent) :`
`39`	`39`	`mShowNoErrorsMessage(true)`
`40`	`40`	`{`
`41`	`41`	`mUI.setupUi(this);`
`42`		`- connect(mUI.mTree, SIGNAL(clicked(const QModelIndex &)), this, SLOT(ItemClicked(const QModelIndex &)));`
	`42`	`+ connect(mUI.mTree, SIGNAL(SelectionChanged(const QModelIndex &)), this, SLOT(UpdateDetails(const QModelIndex &)));`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`void ResultsView::Initialize(QSettings settings, ApplicationList list)`
`@@ -54,13 +54,11 @@ void ResultsView::Initialize(QSettings settings, ApplicationList list)`
`54`	`54`	`mUI.mTree->Initialize(settings, list);`
`55`	`55`	`}`
`56`	`56`
`57`		`-`
`58`	`57`	`ResultsView::~ResultsView()`
`59`	`58`	`{`
`60`	`59`	`//dtor`
`61`	`60`	`}`
`62`	`61`
`63`		`-`
`64`	`62`	`void ResultsView::Clear()`
`65`	`63`	`{`
`66`	`64`	`mUI.mTree->Clear();`
`@@ -266,7 +264,7 @@ void ResultsView::ReadErrorsXml(const QString &filename)`
`266`	`264`	`mUI.mTree->SetCheckDirectory("");`
`267`	`265`	`}`
`268`	`266`
`269`		`-void ResultsView::ItemClicked(const QModelIndex &index)`
	`267`	`+void ResultsView::UpdateDetails(const QModelIndex &index)`
`270`	`268`	`{`
`271`	`269`	`QStandardItemModel model = qobject_cast<QStandardItemModel>(mUI.mTree->model());`
`272`	`270`	`QStandardItem *item = model->itemFromIndex(index);`