Merged revisions 41544-41546,41549-41551,41558-41561,41564,41567,41570,41573,41576-41579,41581,41583-41586,41589,41591,41594-41612,41614-41620,41622-41624,41628,41630-41635,41637,41640-41641,41643,41649-41650 via svnmerge from

jhunold · jhunold · commit 63f8e9f3d732 · 2007-12-16T10:12:07.000Z
https://svn.boost.org/svn/boost/trunk ........ r41544 | jhunold | 2007-12-01 20:27:06 +0100 (Sa, 01 Dez 2007) | 2 lines Silence compiler by adding cosmetic virtual destructors. ........ r41549 | jhunold | 2007-12-01 21:24:51 +0100 (Sa, 01 Dez 2007) | 2 lines Silence compiler by adding cosmetic virtual destructors. ........ r41550 | jhunold | 2007-12-01 21:26:37 +0100 (Sa, 01 Dez 2007) | 3 lines Remove unused paramters. Add -Wextra to gcc flags to enable more warnings. ........ r41577 | jhunold | 2007-12-02 12:51:08 +0100 (So, 02 Dez 2007) | 3 lines Revert revisions 41544 and 41549. See http://lists.boost.org/Archives/boost/2007/12/131116.php for details. ........ r41649 | jhunold | 2007-12-03 19:47:17 +0100 (Mo, 03 Dez 2007) | 2 lines Silence unused paramter warning in release mode. ........ r41650 | jhunold | 2007-12-03 19:51:26 +0100 (Mo, 03 Dez 2007) | 2 lines Add cosmetic virtual detructors to silence compile warnings. ........ [SVN r42094]
diff --git a/include/boost/python/converter/implicit.hpp b/include/boost/python/converter/implicit.hpp
@@ -32,7 +32,7 @@ struct implicit
 
         arg_from_python<Source> get_source(obj);
         bool convertible = get_source.convertible();
-        BOOST_ASSERT(convertible);
+        BOOST_VERIFY(convertible);
         
         new (storage) Target(get_source());
         
diff --git a/include/boost/python/detail/result.hpp b/include/boost/python/detail/result.hpp
@@ -95,7 +95,7 @@ result(X const&, short = 0) { return 0; }
 # define N BOOST_PP_ITERATION()
 
 template <class R BOOST_PP_ENUM_TRAILING_PARAMS_Z(1, N, class A)>
-boost::type<R>* result(R (*pf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)
+boost::type<R>* result(R (*)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)
 {
     return 0;
 }
@@ -120,7 +120,7 @@ boost::type<R>* result(R (*pf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)
 # define Q BOOST_PYTHON_CV_QUALIFIER(BOOST_PP_RELATIVE_ITERATION(1))
 
 template <class R, class T BOOST_PP_ENUM_TRAILING_PARAMS_Z(1, N, class A)>
-boost::type<R>* result(R (T::*pmf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)) Q, int = 0)
+boost::type<R>* result(R (T::*)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)) Q, int = 0)
 {
     return 0;
 }
diff --git a/include/boost/python/detail/unwind_type.hpp b/include/boost/python/detail/unwind_type.hpp
@@ -149,7 +149,7 @@ struct unwind_helper2<reference_to_pointer_>
 template <class Generator, class U>
 inline typename Generator::result_type
 #ifndef _MSC_VER
-unwind_type(boost::type<U>*p, Generator*)
+unwind_type(boost::type<U>*, Generator*)
 #else
 unwind_type(boost::type<U>*p =0, Generator* =0)
 #endif
diff --git a/include/boost/python/to_python_value.hpp b/include/boost/python/to_python_value.hpp
@@ -36,7 +36,7 @@ template <bool is_const_ref>
 struct object_manager_get_pytype
 {
    template <class U>
-   static PyTypeObject const* get( U& (*p)() =0)
+   static PyTypeObject const* get( U& (*)() =0)
    {
       return converter::object_manager_traits<U>::get_pytype();
    }
@@ -46,7 +46,7 @@ template <>
 struct object_manager_get_pytype<true>
 {
    template <class U>
-   static PyTypeObject const* get( U const& (*p)() =0)
+   static PyTypeObject const* get( U const& (*)() =0)
    {
       return converter::object_manager_traits<U>::get_pytype();
    }
diff --git a/test/Jamfile.v2 b/test/Jamfile.v2
@@ -5,7 +5,10 @@
 import python ;
 
 use-project /boost/python : ../build ;
-project /boost/python/test ;
+project /boost/python/test 
+  : requirements
+    <toolset>gcc:<cxxflags>-Wextra
+  ;
 
 local PY = ;
 if [ python.configured ]
diff --git a/test/bienstman1.cpp b/test/bienstman1.cpp
@@ -11,7 +11,7 @@ struct A {};
 
 struct V 
 {
-
+ virtual ~V() {}; // silence compiler warningsa
  virtual void f() = 0;
 
  const A* inside() {return &a;}
diff --git a/test/bienstman3.cpp b/test/bienstman3.cpp
@@ -7,6 +7,7 @@
 
 struct V 
 {
+ virtual ~V() {}; // silence compiler warningsa
  virtual void f() = 0;
 };
 
diff --git a/test/borrowed.cpp b/test/borrowed.cpp
@@ -9,13 +9,13 @@
 using namespace boost::python;
 
 template <class T>
-void assert_borrowed_ptr(T const& x)
+void assert_borrowed_ptr(T const&)
 {
     BOOST_STATIC_ASSERT(boost::python::detail::is_borrowed_ptr<T>::value);
 }
     
 template <class T>
-void assert_not_borrowed_ptr(T const& x)
+void assert_not_borrowed_ptr(T const&)
 {
     BOOST_STATIC_ASSERT(!boost::python::detail::is_borrowed_ptr<T>::value);
 }
diff --git a/test/implicit.cpp b/test/implicit.cpp
@@ -24,6 +24,7 @@ X make_x(int n) { return X(n); }
 struct bar {};
 struct foo
 {
+    virtual ~foo() {}; // silence compiler warnings
     virtual void f() = 0;
     operator bar() const { return bar(); }
 };
diff --git a/test/operators_wrapper.cpp b/test/operators_wrapper.cpp
@@ -5,10 +5,10 @@ struct vector
 {
     virtual ~vector() {}
     
-    vector operator+( const vector& x ) const
+    vector operator+( const vector& ) const
     { return vector(); }
 
-    vector& operator+=( const vector& x )
+    vector& operator+=( const vector& )
     { return *this; }
     
     vector operator-() const
diff --git a/test/pointer_vector.cpp b/test/pointer_vector.cpp
@@ -10,6 +10,7 @@ using namespace boost::python;
 class Abstract
 {
 public:   
+    virtual ~Abstract() {}; // silence compiler warningsa
     virtual std::string    f() =0;
 };
 
diff --git a/test/shared_ptr.cpp b/test/shared_ptr.cpp
@@ -129,6 +129,7 @@ shared_ptr<Y> factory(int n)
 // regressions from Nicodemus
     struct A
     {
+        virtual ~A() {}; // silence compiler warnings
         virtual int f() = 0;
         static int call_f(shared_ptr<A>& a) { return a->f(); }
     };
diff --git a/test/wrapper_held_type.cpp b/test/wrapper_held_type.cpp
@@ -13,6 +13,7 @@
 
 struct data
 {
+    virtual ~data() {}; // silence compiler warnings
     virtual int id() const
     {
         return 42;

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,7 @@ result(X const&, short = 0) { return 0; }`
`95`	`95`	`# define N BOOST_PP_ITERATION()`
`96`	`96`
`97`	`97`	`template <class R BOOST_PP_ENUM_TRAILING_PARAMS_Z(1, N, class A)>`
`98`		`-boost::type<R>* result(R (*pf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)`
	`98`	`+boost::type<R>* result(R (*)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)`
`99`	`99`	`{`
`100`	`100`	`return 0;`
`101`	`101`	`}`
`@@ -120,7 +120,7 @@ boost::type<R>* result(R (*pf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)), int = 0)`
`120`	`120`	`# define Q BOOST_PYTHON_CV_QUALIFIER(BOOST_PP_RELATIVE_ITERATION(1))`
`121`	`121`
`122`	`122`	`template <class R, class T BOOST_PP_ENUM_TRAILING_PARAMS_Z(1, N, class A)>`
`123`		`-boost::type<R>* result(R (T::*pmf)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)) Q, int = 0)`
	`123`	`+boost::type<R>* result(R (T::*)(BOOST_PP_ENUM_PARAMS_Z(1, N, A)) Q, int = 0)`
`124`	`124`	`{`
`125`	`125`	`return 0;`
`126`	`126`	`}`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ template <bool is_const_ref>`
`36`	`36`	`struct object_manager_get_pytype`
`37`	`37`	`{`
`38`	`38`	`template <class U>`
`39`		`- static PyTypeObject const* get( U& (*p)() =0)`
	`39`	`+ static PyTypeObject const* get( U& (*)() =0)`
`40`	`40`	`{`
`41`	`41`	`return converter::object_manager_traits<U>::get_pytype();`
`42`	`42`	`}`
`@@ -46,7 +46,7 @@ template <>`
`46`	`46`	`struct object_manager_get_pytype<true>`
`47`	`47`	`{`
`48`	`48`	`template <class U>`
`49`		`- static PyTypeObject const* get( U const& (*p)() =0)`
	`49`	`+ static PyTypeObject const* get( U const& (*)() =0)`
`50`	`50`	`{`
`51`	`51`	`return converter::object_manager_traits<U>::get_pytype();`
`52`	`52`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,7 @@ struct A {};`
`11`	`11`
`12`	`12`	`struct V`
`13`	`13`	`{`
`14`		`-`
	`14`	`+ virtual ~V() {}; // silence compiler warningsa`
`15`	`15`	`virtual void f() = 0;`
`16`	`16`
`17`	`17`	`const A* inside() {return &a;}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,7 @@`
`7`	`7`
`8`	`8`	`struct V`
`9`	`9`	`{`
	`10`	`+ virtual ~V() {}; // silence compiler warningsa`
`10`	`11`	`virtual void f() = 0;`
`11`	`12`	`};`
`12`	`13`
Original file line number	Diff line number	Diff line change
`@@ -9,13 +9,13 @@`
`9`	`9`	`using namespace boost::python;`
`10`	`10`
`11`	`11`	`template <class T>`
`12`		`-void assert_borrowed_ptr(T const& x)`
	`12`	`+void assert_borrowed_ptr(T const&)`
`13`	`13`	`{`
`14`	`14`	`BOOST_STATIC_ASSERT(boost::python::detail::is_borrowed_ptr<T>::value);`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`template <class T>`
`18`		`-void assert_not_borrowed_ptr(T const& x)`
	`18`	`+void assert_not_borrowed_ptr(T const&)`
`19`	`19`	`{`
`20`	`20`	`BOOST_STATIC_ASSERT(!boost::python::detail::is_borrowed_ptr<T>::value);`
`21`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ X make_x(int n) { return X(n); }`
`24`	`24`	`struct bar {};`
`25`	`25`	`struct foo`
`26`	`26`	`{`
	`27`	`+ virtual ~foo() {}; // silence compiler warnings`
`27`	`28`	`virtual void f() = 0;`
`28`	`29`	`operator bar() const { return bar(); }`
`29`	`30`	`};`