Fix quantum client exception when server returns 500 error.

Dan Wendlandt · Dan Wendlandt · commit d0a68cbf92af · 2012-03-29T15:00:04.000-07:00
bug 963494

Also, make sure that exceptions within the client are accompanied with
a full stack trace, otherwise it is hard to track down where it happened.

Change-Id: Ic134ed27523b2c321dcb8e35e6ab0eb144a699f3
diff --git a/quantum/client/__init__.py b/quantum/client/__init__.py
@@ -115,7 +115,8 @@ def exception_handler_v11(status_code, error_content):
                          message=error_message)],)
         raise ex
     # If we end up here the exception was not a quantum error
-    raise exceptions.QuantumClientException(status_code + "-" + error_content)
+    msg = "%s-%s" % (status_code, error_content)
+    raise exceptions.QuantumClientException(message=msg)
 
 
 EXCEPTION_HANDLERS = {
diff --git a/quantum/client/cli_lib.py b/quantum/client/cli_lib.py
@@ -23,6 +23,7 @@
 import logging
 import os
 import sys
+import traceback
 
 FORMAT = "json"
 LOG = logging.getLogger('quantum.client.cli_lib')
@@ -192,7 +193,6 @@ def __init__(self, cmd, data, version):
 
 
 def _handle_exception(ex):
-    LOG.exception(sys.exc_info())
     status_code = None
     message = None
     # Retrieve dict at 1st element of tuple at last argument
@@ -202,12 +202,10 @@ def _handle_exception(ex):
         msg_1 = "Command failed with error code: %s" \
                 % (status_code or '<missing>')
         msg_2 = "Error message:%s" % (message or '<missing>')
-        LOG.exception(msg_1 + "-" + msg_2)
         print msg_1
         print msg_2
     else:
-        print "An unexpected exception occured:%s (%s)" % (sys.exc_info()[1],
-                                                           sys.exc_info()[0])
+        traceback.print_exc()
 
 
 def prepare_output(cmd, tenant_id, response, version):
