Add update method of security group name and description

niuzhenguo · niuzhenguo · commit 9dbc2c799763 · 2013-05-15T17:36:37.000+08:00
make it possible to edit the name and description of security groups.

Fixes: bug #918393

Change-Id: I7b9dd3f9ad2f59aee1b37e06350ce8f5e3a40f64
diff --git a/quantumclient/quantum/v2_0/securitygroup.py b/quantumclient/quantum/v2_0/securitygroup.py
@@ -73,6 +73,31 @@ class DeleteSecurityGroup(quantumv20.DeleteCommand):
     allow_names = True
 
 
+class UpdateSecurityGroup(quantumv20.UpdateCommand):
+    """Update a given security group."""
+
+    log = logging.getLogger(__name__ + '.UpdateSecurityGroup')
+    resource = 'security_group'
+
+    def add_known_arguments(self, parser):
+        parser.add_argument(
+            '--name',
+            help='Name of security group')
+        parser.add_argument(
+            '--description',
+            help='description of security group')
+
+    def args2body(self, parsed_args):
+        body = {'security_group': {}}
+        if parsed_args.name:
+            body['security_group'].update(
+                {'name': parsed_args.name})
+        if parsed_args.description:
+            body['security_group'].update(
+                {'description': parsed_args.description})
+        return body
+
+
 class ListSecurityGroupRule(quantumv20.ListCommand):
     """List security group rules that belong to a given tenant."""
 
diff --git a/quantumclient/shell.py b/quantumclient/shell.py
@@ -150,6 +150,8 @@ def env(*_vars, **kwargs):
         'quantumclient.quantum.v2_0.securitygroup.CreateSecurityGroup'),
     'security-group-delete': utils.import_class(
         'quantumclient.quantum.v2_0.securitygroup.DeleteSecurityGroup'),
+    'security-group-update': utils.import_class(
+        'quantumclient.quantum.v2_0.securitygroup.UpdateSecurityGroup'),
     'security-group-rule-list': utils.import_class(
         'quantumclient.quantum.v2_0.securitygroup.ListSecurityGroupRule'),
     'security-group-rule-show': utils.import_class(
diff --git a/quantumclient/v2_0/client.py b/quantumclient/v2_0/client.py
@@ -470,6 +470,14 @@ def create_security_group(self, body=None):
         """
         return self.post(self.security_groups_path, body=body)
 
+    @APIParamsCall
+    def update_security_group(self, security_group, body=None):
+        """
+        Updates a security group
+        """
+        return self.put(self.security_group_path %
+                        security_group, body=body)
+
     @APIParamsCall
     def list_security_groups(self, retrieve_all=True, **_params):
         """
diff --git a/tests/unit/test_cli20_securitygroup.py b/tests/unit/test_cli20_securitygroup.py
@@ -118,6 +118,29 @@ def test_delete_security_group(self):
         args = [myid]
         self._test_delete_resource(resource, cmd, myid, args)
 
+    def test_update_security_group(self):
+        """Update security group: myid --name myname --description desc."""
+        resource = 'security_group'
+        cmd = securitygroup.UpdateSecurityGroup(
+            test_cli20.MyApp(sys.stdout), None)
+        self._test_update_resource(resource, cmd, 'myid',
+                                   ['myid', '--name', 'myname',
+                                    '--description', 'mydescription'],
+                                   {'name': 'myname',
+                                    'description': 'mydescription'}
+                                   )
+
+    def test_update_security_group_with_unicode(self):
+        resource = 'security_group'
+        cmd = securitygroup.UpdateSecurityGroup(
+            test_cli20.MyApp(sys.stdout), None)
+        self._test_update_resource(resource, cmd, 'myid',
+                                   ['myid', '--name', u'\u7f51\u7edc',
+                                    '--description', u'\u7f51\u7edc'],
+                                   {'name': u'\u7f51\u7edc',
+                                    'description': u'\u7f51\u7edc'}
+                                   )
+
     def test_create_security_group_rule_full(self):
         """Create security group rule."""
         resource = 'security_group_rule'
